Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: port RingTheory.TensorProduct #3649

Closed
wants to merge 19 commits into from
Closed

feat: port RingTheory.TensorProduct #3649

wants to merge 19 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

Open in Gitpod

@Ruben-VandeVelde
feat: port RingTheory.TensorProduct
6d7df46
@Ruben-VandeVelde
Initial file copy from mathport
113c90e
@Ruben-VandeVelde
automated fixes
2e03ea1 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Ruben-VandeVelde
Initial fixes
e7ef177
@Ruben-VandeVelde Ruben-VandeVelde added help-wanted The author needs attention to resolve issues mathlib-port This is a port of a theory file from mathlib. please-adopt labels Apr 25, 2023
@kbuzzard
Copy link
Member

kbuzzard commented May 8, 2023

So #3840 solved a couple of problems with this file :-) I've removed a couple more errors but am stumped by line 434.

@kbuzzard kbuzzard mentioned this pull request May 15, 2023
Closed
1 task
@kbuzzard
Copy link
Member

I have this almost sorry-free with the enableeta branch merged into this, in #4004 .

@semorrison
Copy link
Contributor

Closing this in favour of #4004.

@semorrison semorrison closed this May 16, 2023
@int-y1 int-y1 deleted the port/RingTheory.TensorProduct branch July 1, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
help-wanted The author needs attention to resolve issues mathlib-port This is a port of a theory file from mathlib. please-adopt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ruben-VandeVelde @kbuzzard @semorrison @eric-wieser @jjaassoonn