Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: Rename to Grp #3731

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - chore: Rename to Grp #3731

wants to merge 3 commits into from

Conversation

YaelDillies
Copy link
Collaborator

This is a proposal to rename what was in mathlib Group and in mathlib4 GroupCat to its literature name Grp. This has the advantage not to conflict with group that has been capitalised to Group and to be shorter.


A similar decision could be applied to ModuleCat and MonCat.

Open in Gitpod

@joelriou
Copy link
Collaborator

The Cat suffix was added intentionally, see
https://github.com/leanprover-community/mathlib4/wiki/Porting-wiki#categories "Categories are suffixed with Cat"

@YaelDillies
Copy link
Collaborator Author

Yes I know. This is an alternative to that last resort solution.

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Apr 29, 2023
@YaelDillies YaelDillies removed wontfix merge-conflict The PR has a merge conflict with master, and needs manual merging. labels May 1, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label May 10, 2023
@fpvandoorn
Copy link
Member

Please reach a consensus about this renaming on Zulip first

@fpvandoorn fpvandoorn added the awaiting-author A reviewer has asked the author a question or requested changes label May 26, 2023
@YaelDillies
Copy link
Collaborator Author

It seems like the consensus is that this is a good thing. @semorrison, can you confirm?

@urkud
Copy link
Member

urkud commented Jun 29, 2023

Could you link to Zulip discussion, please?

@semorrison semorrison added the t-category-theory Category theory label Aug 6, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Aug 27, 2023
@YaelDillies
Copy link
Collaborator Author

@YaelDillies YaelDillies added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 27, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Aug 29, 2023
@bors bors bot changed the base branch from master to ScottCarnahan/BinomialRing2 September 17, 2023 03:23
@semorrison semorrison changed the base branch from ScottCarnahan/BinomialRing2 to master September 17, 2023 12:18
Mathlib.lean Outdated Show resolved Hide resolved
Mathlib.lean Show resolved Hide resolved
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Nov 24, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 2, 2023
Mathlib.lean Show resolved Hide resolved
Mathlib.lean Outdated Show resolved Hide resolved
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Mar 2, 2024
Copy link

github-actions bot commented Jun 7, 2024

Import summary

Dependency changes
File Base Count Head Count Change
Mathlib.Algebra.Category.GroupCat.EquivalenceGroupAddGroup 490 0 -490 (-100.00%)
Mathlib.Analysis.Normed.Group.SemiNormedGroupCat 1114 0 -1114 (-100.00%)

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Jun 7, 2024
Copy link

github-actions bot commented Jun 8, 2024

PR summary d7c9e44165

Import changes

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.Category.GroupCat.EquivalenceGroupAddGroup 461 0 -461 (-100.00%)
Mathlib.Analysis.Normed.Group.SemiNormedGroupCat 1094 0 -1094 (-100.00%)

Declarations diff

+ AddCommGrp.coyonedaObjIsoForget
+ AddCommGrp.forget_corepresentable
+ AddGrp.coyonedaObjIsoForget
+ AddGrp.forget_corepresentable
+ CommGrp
+ CommGrp.coyonedaObjIsoForget
+ CommGrp.forget_corepresentable
+ CommGrp.forget_reflects_isos
+ CommGrp.forget₂CommMonAdj
+ Grp
+ Grp.coyonedaObjIsoForget
+ Grp.forget_corepresentable
+ Grp.forget_reflects_isos
+ Grp.forget₂MonAdj
+ GrpWithZero
+ MonoidHom.comp_id_commGrp
+ MonoidHom.comp_id_grp
+ MonoidHom.id_commGrp_comp
+ MonoidHom.id_grp_comp
+ MulEquiv.toCommGrpIso
+ MulEquiv.toGrpIso
+ MulEquiv.toSemigrpIso
+ SemiNormedGrp
+ SemiNormedGrp₁
+ Semigrp
+ Semigrp.forgetReflectsIsos
+ Semigrp.forget₂_full
+ forget_commGrp_preserves_epi
+ forget_commGrp_preserves_mono
+ forget_grp_preserves_epi
+ forget_grp_preserves_mono
+ forget₂_addCommGrp_additive
+ forget₂_addCommGrp_essSurj
+ hasForgetToAddCommGrp
+ instance (G : CommGrp) : CommGroup <| (forget CommGrp).obj G
+ instance (G : Grp) : Group G.α
+ instance (G H : CommGrp) : One (G ⟶ H) := (inferInstance : One (MonoidHom G H))
+ instance (G H : Grp) : One (G ⟶ H) := (inferInstance : One (MonoidHom G H))
+ instance (M : SemiNormedGrp) : SeminormedAddCommGroup M
+ instance (M : SemiNormedGrp₁) : SeminormedAddCommGroup M
+ instance (P Q : AddCommGrp) : AddCommGroup (P ⟶ Q)
+ instance (X : Grp) : Group X := X.str
+ instance (X : GrpWithZero) : GroupWithZero X
+ instance (X : Semigrp) : Semigroup X := X.str
+ instance (X Y : SemiNormedGrp₁) : Zero (X ⟶ Y)
+ instance : (forget AddCommGrp.{u}).IsRightAdjoint
+ instance : (forget Grp.{u}).IsRightAdjoint
+ instance : (forget₂ (ModuleCat.{v} R) AddCommGrp.{v}).ReflectsIsomorphisms
+ instance : (forget₂ CommGrp.{u} Grp.{u}).ReflectsIsomorphisms
+ instance : Abelian AddCommGrp.{u}
+ instance : Coe CommGrp.{u} CommMonCat.{u} where coe := (forget₂ CommGrp CommMonCat).obj
+ instance : Coe CommGrp.{u} Grp.{u} where coe := (forget₂ CommGrp Grp).obj
+ instance : Coe Grp.{u} MonCat.{u} where coe := (forget₂ Grp MonCat).obj
+ instance : CoeSort CommGrp Type*
+ instance : CoeSort Grp Type*
+ instance : CoeSort GrpWithZero Type*
+ instance : CoeSort SemiNormedGrp Type*
+ instance : CoeSort SemiNormedGrp₁ Type*
+ instance : CoeSort Semigrp Type*
+ instance : ConcreteCategory SemiNormedGrp := by
+ instance : ConcreteCategory.{u} SemiNormedGrp₁
+ instance : HasBinaryBiproducts AddCommGrp
+ instance : HasCokernels SemiNormedGrp.{u}
+ instance : HasCokernels SemiNormedGrp₁.{u}
+ instance : HasColimitsOfSize.{0, 0} (AddCommGrp.{u}) := hasColimitsOfSize.{u, 0, 0}
+ instance : HasColimitsOfSize.{u, u} (AddCommGrpMax.{u, v}) := hasColimitsOfSize.{v}
+ instance : HasColimitsOfSize.{u, v} (AddCommGrpMax.{u, v}) := hasColimitsOfSize.{u}
+ instance : HasColimitsOfSize.{v, u} (AddCommGrpMax.{u, v}) := hasColimitsOfSize.{u}
+ instance : HasColimitsOfSize.{v, v} (AddCommGrpMax.{u, v}) := hasColimitsOfSize.{u}
+ instance : HasFiniteBiproducts AddCommGrp
+ instance : HasForget₂ SemiNormedGrp₁ SemiNormedGrp
+ instance : HasZeroObject CommGrp
+ instance : HasZeroObject Grp
+ instance : Inhabited (Action AddCommGrp G)
+ instance : Inhabited CommGrp
+ instance : Inhabited Grp
+ instance : Inhabited GrpWithZero
+ instance : Inhabited SemiNormedGrp
+ instance : Inhabited SemiNormedGrp₁
+ instance : Inhabited Semigrp
+ instance : LargeCategory.{u} GrpWithZero
+ instance : LargeCategory.{u} SemiNormedGrp₁
+ instance : Limits.HasEqualizers.{u, u + 1} SemiNormedGrp
+ instance : Limits.HasZeroMorphisms.{u, u + 1} SemiNormedGrp
+ instance : Limits.HasZeroMorphisms.{u, u + 1} SemiNormedGrp₁
+ instance : Preadditive AddCommGrp
+ instance : Preadditive SemiNormedGrp.{u}
+ instance : PreservesColimit F (forget₂ _ AddCommGrp)
+ instance : Small.{u} (Functor.sections ((F ⋙ forget₂ Grp MonCat) ⋙ forget MonCat))
+ instance _root_.AddCommGrp.forgetPreservesLimits :
+ instance {M N : GrpWithZero} : FunLike (M ⟶ N) M N
+ instance {M N : SemiNormedGrp} : Zero (M ⟶ N)
+ instance {V W : SemiNormedGrp.{u}} : NNNorm (V ⟶ W)
+ instance {V W : SemiNormedGrp.{u}} : Norm (V ⟶ W)
+ instance {V W : SemiNormedGrp.{u}} : Sub (V ⟶ W)
+ instance {X Y : CommGrp} : CoeFun (X ⟶ Y) fun _ => X → Y
+ instance {X Y : Grp} : CoeFun (X ⟶ Y) fun _ => X → Y
+ mulEquivIsoSemigrpIso
+ semigrpIsoToMulEquiv
+ toAddCommGrp
+ toAddGrp
+ toCommGrp
+ toGrp
+ wellPowered_addCommGrp
- AddCommGroupCat.coyonedaObjIsoForget
- AddCommGroupCat.forget_corepresentable
- AddGroupCat.coyonedaObjIsoForget
- AddGroupCat.forget_corepresentable
- CommGroupCat
- CommGroupCat.coyonedaObjIsoForget
- CommGroupCat.forget_corepresentable
- CommGroupCat.forget_reflects_isos
- CommGroupCat.forget₂CommMonAdj
- GroupCat
- GroupCat.coyonedaObjIsoForget
- GroupCat.forget_corepresentable
- GroupCat.forget_reflects_isos
- GroupCat.forget₂MonAdj
- GroupWithZeroCat
- MonoidHom.comp_id_commGroupCat
- MonoidHom.comp_id_groupCat
- MonoidHom.id_commGroupCat_comp
- MonoidHom.id_groupCat_comp
- MulEquiv.toCommGroupCatIso
- MulEquiv.toGroupCatIso
- MulEquiv.toSemigroupCatIso
- SemiNormedGroupCat
- SemiNormedGroupCat₁
- SemigroupCat
- SemigroupCat.forgetReflectsIsos
- SemigroupCat.forget₂_full
- forget_commGroupCat_preserves_epi
- forget_commGroupCat_preserves_mono
- forget_groupCat_preserves_epi
- forget_groupCat_preserves_mono
- forget₂_addCommGroupCat_additive
- forget₂_addCommGroupCat_essSurj
- hasForgetToAddCommGroupCat
- instance (G : CommGroupCat) : CommGroup <| (forget CommGroupCat).obj G
- instance (G : GroupCat) : Group G.α
- instance (G H : CommGroupCat) : One (G ⟶ H) := (inferInstance : One (MonoidHom G H))
- instance (G H : GroupCat) : One (G ⟶ H) := (inferInstance : One (MonoidHom G H))
- instance (M : SemiNormedGroupCat) : SeminormedAddCommGroup M
- instance (M : SemiNormedGroupCat₁) : SeminormedAddCommGroup M
- instance (P Q : AddCommGroupCat) : AddCommGroup (P ⟶ Q)
- instance (X : GroupCat) : Group X := X.str
- instance (X : GroupWithZeroCat) : GroupWithZero X
- instance (X : SemigroupCat) : Semigroup X := X.str
- instance (X Y : SemiNormedGroupCat₁) : Zero (X ⟶ Y)
- instance : (forget AddCommGroupCat.{u}).IsRightAdjoint
- instance : (forget GroupCat.{u}).IsRightAdjoint
- instance : (forget₂ (ModuleCat.{v} R) AddCommGroupCat.{v}).ReflectsIsomorphisms
- instance : (forget₂ CommGroupCat.{u} GroupCat.{u}).ReflectsIsomorphisms
- instance : Abelian AddCommGroupCat.{u}
- instance : Coe CommGroupCat.{u} CommMonCat.{u} where coe := (forget₂ CommGroupCat CommMonCat).obj
- instance : Coe CommGroupCat.{u} GroupCat.{u} where coe := (forget₂ CommGroupCat GroupCat).obj
- instance : Coe GroupCat.{u} MonCat.{u} where coe := (forget₂ GroupCat MonCat).obj
- instance : CoeSort CommGroupCat Type*
- instance : CoeSort GroupCat Type*
- instance : CoeSort GroupWithZeroCat Type*
- instance : CoeSort SemiNormedGroupCat Type*
- instance : CoeSort SemiNormedGroupCat₁ Type*
- instance : CoeSort SemigroupCat Type*
- instance : ConcreteCategory SemiNormedGroupCat := by
- instance : ConcreteCategory.{u} SemiNormedGroupCat₁
- instance : HasBinaryBiproducts AddCommGroupCat
- instance : HasCokernels SemiNormedGroupCat.{u}
- instance : HasCokernels SemiNormedGroupCat₁.{u}
- instance : HasColimitsOfSize.{0, 0} (AddCommGroupCat.{u}) := hasColimitsOfSize.{u, 0, 0}
- instance : HasColimitsOfSize.{u, u} (AddCommGroupCatMax.{u, v}) := hasColimitsOfSize.{v}
- instance : HasColimitsOfSize.{u, v} (AddCommGroupCatMax.{u, v}) := hasColimitsOfSize.{u}
- instance : HasColimitsOfSize.{v, u} (AddCommGroupCatMax.{u, v}) := hasColimitsOfSize.{u}
- instance : HasColimitsOfSize.{v, v} (AddCommGroupCatMax.{u, v}) := hasColimitsOfSize.{u}
- instance : HasFiniteBiproducts AddCommGroupCat
- instance : HasForget₂ SemiNormedGroupCat₁ SemiNormedGroupCat
- instance : HasZeroObject CommGroupCat
- instance : HasZeroObject GroupCat
- instance : Inhabited (Action AddCommGroupCat G)
- instance : Inhabited CommGroupCat
- instance : Inhabited GroupCat
- instance : Inhabited GroupWithZeroCat
- instance : Inhabited SemiNormedGroupCat
- instance : Inhabited SemiNormedGroupCat₁
- instance : Inhabited SemigroupCat
- instance : LargeCategory.{u} GroupWithZeroCat
- instance : LargeCategory.{u} SemiNormedGroupCat₁
- instance : Limits.HasEqualizers.{u, u + 1} SemiNormedGroupCat
- instance : Limits.HasZeroMorphisms.{u, u + 1} SemiNormedGroupCat
- instance : Limits.HasZeroMorphisms.{u, u + 1} SemiNormedGroupCat₁
- instance : Preadditive AddCommGroupCat
- instance : Preadditive SemiNormedGroupCat.{u}
- instance : PreservesColimit F (forget₂ _ AddCommGroupCat)
- instance : Small.{u} (Functor.sections ((F ⋙ forget₂ GroupCat MonCat) ⋙ forget MonCat))
- instance _root_.AddCommGroupCat.forgetPreservesLimits :
- instance {M N : GroupWithZeroCat} : FunLike (M ⟶ N) M N
- instance {M N : SemiNormedGroupCat} : Zero (M ⟶ N)
- instance {V W : SemiNormedGroupCat.{u}} : NNNorm (V ⟶ W)
- instance {V W : SemiNormedGroupCat.{u}} : Norm (V ⟶ W)
- instance {V W : SemiNormedGroupCat.{u}} : Sub (V ⟶ W)
- instance {X Y : CommGroupCat} : CoeFun (X ⟶ Y) fun _ => X → Y
- instance {X Y : GroupCat} : CoeFun (X ⟶ Y) fun _ => X → Y
- mulEquivIsoSemigroupCatIso
- semigroupCatIsoToMulEquiv
- toAddCommGroupCat
- toAddGroupCat
- toCommGroupCat
- toGroupCat
- wellPowered_addCommGroupCat
-+-+ adj
-+-+ comp_def
-+-+ concreteCategory
-+-+ enoughInjectives
-+-+ forgetPreservesLimits
-+-+ free
-+-+ hasColimitsOfShape
-+-+ hasColimitsOfSize
-+-+ hasLimits
-+-+ hasLimitsOfShape
-+-+ hasLimitsOfSize
-+-+ one_apply
-+-+ uliftFunctor
-+-+-+ colimit
-+-+-+ ext
-+-+-+-+ instFunLike
-+-+-+--++ coe_of
-+-+--++ isZero_of_subsingleton
-+-+--++ ofUnique
-+-+--++-+-+ of
-+--++ forget_map
-+--++--++ coe_comp
-+--++--++ coe_id
--++ cokernelCocone
--++ cokernelLift
--++ hasZeroObject
--++ toAddMonoidHomClass
--++ zero_apply

You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>

## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Jun 8, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Jun 14, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Jun 17, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jun 19, 2024
@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 20, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jun 20, 2024
This is a proposal to rename what was in mathlib `Group` and in mathlib4 `GroupCat` to its literature name `Grp`. This has the advantage not to conflict with `group` that has been capitalised to `Group` and to be shorter.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 20, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: Rename to Grp [Merged by Bors] - chore: Rename to Grp Jun 20, 2024
@mathlib-bors mathlib-bors bot closed this Jun 20, 2024
@mathlib-bors mathlib-bors bot deleted the Grp branch June 20, 2024 02:21
AntoineChambert-Loir pushed a commit that referenced this pull request Jun 20, 2024
This is a proposal to rename what was in mathlib `Group` and in mathlib4 `GroupCat` to its literature name `Grp`. This has the advantage not to conflict with `group` that has been capitalised to `Group` and to be shorter.
kbuzzard pushed a commit that referenced this pull request Jun 26, 2024
This is a proposal to rename what was in mathlib `Group` and in mathlib4 `GroupCat` to its literature name `Grp`. This has the advantage not to conflict with `group` that has been capitalised to `Group` and to be shorter.
dagurtomas pushed a commit that referenced this pull request Jul 2, 2024
This is a proposal to rename what was in mathlib `Group` and in mathlib4 `GroupCat` to its literature name `Grp`. This has the advantage not to conflict with `group` that has been capitalised to `Group` and to be shorter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-category-theory Category theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants