Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port LinearAlgebra.CrossProduct #3736

Closed
wants to merge 13 commits into from
Closed

[Merged by Bors] - feat: port LinearAlgebra.CrossProduct #3736

wants to merge 13 commits into from

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented Apr 29, 2023

Open in Gitpod

@int-y1
feat: port LinearAlgebra.CrossProduct
672cefb
@int-y1
Initial file copy from mathport
2d55a2a
@int-y1
automated fixes
4e6956e 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@int-y1
fix crossProduct
d6df935
@int-y1 int-y1 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. eta-experiment labels Apr 29, 2023
@int-y1
Copy link
Collaborator Author

int-y1 commented Apr 29, 2023 •
edited

todo:

  • simpNF linter for dot_self_cross dot_cross_self
  • (optional) find a better alternative for vecCons2

@int-y1 int-y1 added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels Apr 29, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label May 2, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label May 3, 2023
@ChrisHughes24
Copy link
Member

bors merge

@ChrisHughes24 ChrisHughes24 removed the help-wanted The author needs attention to resolve issues label May 20, 2023
@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label May 20, 2023
bors bot pushed a commit that referenced this pull request May 20, 2023
@int-y1
feat: port LinearAlgebra.CrossProduct (#3736)
ddd8e1d
@bors
Copy link

bors bot commented May 20, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port LinearAlgebra.CrossProduct [Merged by Bors] - feat: port LinearAlgebra.CrossProduct May 20, 2023
@bors bors bot closed this May 20, 2023
@bors bors bot deleted the port/LinearAlgebra.CrossProduct branch May 20, 2023 13:00
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@int-y1 @qawbecrdtey
feat: port LinearAlgebra.CrossProduct (leanprover-community#3736)
50f9e02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@int-y1 @ChrisHughes24 @semorrison