[Merged by Bors] - feat: port CategoryTheory.Monoidal.Free.Coherence #3769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
….Monoidal.Free.Basic
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
joelriou
added
WIP
…e.Basic' into port/CategoryTheory.Monoidal.Free.Coherence
semorrison
removed
the
blocked-by-other-PR
|
This PR/issue depends on:
|
semorrison
added
the
merge-conflict
…al.Free.Coherence
semorrison
removed
the
merge-conflict
joelriou
added
awaiting-review
and removed
help-wanted
|
✌️ joelriou can now approve this pull request. To approve and merge a pull request, simply reply with |
mattrobball
reviewed
May 18, 2023
|
|
||
| end | ||
|
|
||
| set_option maxHeartbeats 400000 in |
There was a problem hiding this comment.
Is this still necessary with #3414?
mattrobball
reviewed
May 18, 2023
| -- porting note: triggers a PANIC "invalid LCNF substitution of free variable | ||
| -- with expression CategoryTheory.FreeMonoidalCategory.NormalMonoidalObject.{u}" | ||
| -- prevented with dsimp [normalizeObj] | ||
| -- the @[simp] attribute is removed because it also triggers a PANIC |
There was a problem hiding this comment.
Can this be restored now?
mattrobball
reviewed
May 18, 2023
|
|
||
| -- porting note: triggers a PANIC "invalid LCNF substitution of free variable | ||
| -- with expression CategoryTheory.FreeMonoidalCategory.NormalMonoidalObject.{u}" | ||
| -- prevented with dsimp [normalizeObj] |
There was a problem hiding this comment.
Is dsimp enough to prevent the panics?
|
Yes |
|
And the bump to max heartbeats can indeed be removed after #3414 |
…al.Free.Coherence
Co-authored-by: Johan Commelin <johan@commelin.net>
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 19, 2023
Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Joël Riou <joel.riou@universite-paris-saclay.fr> Co-authored-by: Matthew Ballard <matt@mrb.email> Co-authored-by: Joël Riou <37772949+joelriou@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://leanprover.zulipchat.com/#narrow/stream/144837-PR-reviews/topic/!4.232808.20CategoryTheory.2EMonoidal.2EFree.2EBasic/near/355402986