Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Topology.Category.Top.Limits.Pullbacks #3802

Closed
wants to merge 31 commits into from
Closed

[Merged by Bors] - feat: port Topology.Category.Top.Limits.Pullbacks #3802

wants to merge 31 commits into from

Conversation

mattrobball
Copy link
Collaborator

@mattrobball mattrobball commented May 5, 2023 •
edited by github-actions bot

mattrobball and others added 16 commits April 28, 2023 09:41
@mattrobball
feat: port Topology.Category.Top.Limits.Products
83ae7b1
@mattrobball
Initial file copy from mathport
f897d40
@mattrobball
automated fixes
947e72a 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@mattrobball
restore changes from #3487
59fdc41
@mattrobball
fix a few things
86f88b6
@mo271
partial fix of prodBinaryFanIsLimit
ea3d165
@mattrobball
Merge branch 'master' into port/Topology.Category.Top.Limits.Products
398e212
@mattrobball
fix last errors
64a90cb
@mattrobball
streamline coercion from X:TopCat to TopologicalSpace X
737618e
@mattrobball
feat: port Topology.Category.Top.Limits.Pullbacks
0042680
@mattrobball
Initial file copy from mathport
aa5bbb2
@mattrobball
automated fixes
2c81d77 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@mattrobball
add products file
6ccad92
@mattrobball
restore changes from #3487
629a95c
@mattrobball
Merge branch 'port/Topology.Category.Top.Limits.Products' into port/T…
aa78108 
…opology.Category.Top.Limits.Pullbacks
@mattrobball
fix a few more errors
5818755
@mattrobball mattrobball added mathlib-port This is a port of a theory file from mathlib. WIP Work in progress labels May 5, 2023
@mattrobball mattrobball added awaiting-review The author would like community review of the PR and removed WIP Work in progress awaiting-review The author would like community review of the PR labels May 6, 2023
@semorrison semorrison added the blocked-by-math-PR This PR depends on another PR to Mathlib label May 6, 2023
@mattrobball mattrobball force-pushed the port/Topology.Category.Top.Limits.Pullbacks branch from 1255699 to 4a099ca Compare May 6, 2023 01:59
@semorrison
Copy link
Contributor

This PR/issue depends on:

@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label May 10, 2023
@mattrobball mattrobball added the awaiting-review The author would like community review of the PR label May 11, 2023
jcommelin
jcommelin reviewed May 11, 2023
View reviewed changes
Mathlib/Topology/Category/Top/Limits/Pullbacks.lean
#align Top.pullback_iso_prod_subtype_hom_snd TopCat.pullbackIsoProdSubtype_hom_snd

-- Porting note: why do I need to tell Lean to coerce pullback to a type
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this will become easier after #3900 ...

Mathlib/Topology/Category/Top/Limits/Pullbacks.lean Outdated
BinaryCofan.mk (⟨Sum.inl, by continuity⟩ : X ⟶ TopCat.of (Sum X Y)) ⟨Sum.inr, by continuity⟩
#align Top.binary_cofan TopCat.binaryCofan

/-- The constructed binary coproduct cofan in `TopCat` is the coproduct. -/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the next 100 lines new? Or did this move in ml3 during the porting of this file? I don't see it when comparing to the mathport output that this port started from...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. These should be at the end of Products.lean. I've moved them back.

jcommelin
jcommelin reviewed May 12, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 12, 2023
bors bot pushed a commit that referenced this pull request May 12, 2023
@mattrobball @mo271
feat: port Topology.Category.Top.Limits.Pullbacks (#3802)
b58e942 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Matthew Robert Ballard <100034030+mattrobball@users.noreply.github.com>
@bors
Copy link

bors bot commented May 12, 2023

Build failed (retrying...):

@ChrisHughes24
Copy link
Member

There was a failure in this file.

bors r-

@bors
Copy link

bors bot commented May 12, 2023

Canceled.

@ChrisHughes24 ChrisHughes24 added awaiting-author A reviewer has asked the author a question or requested changes and removed ready-to-merge This PR has been sent to bors. labels May 12, 2023
@mattrobball
Copy link
Collaborator Author

mattrobball commented May 12, 2023 •
edited

Conflict with the casing of ConcreteCategory.forget from #3900. No other changes from bors attempt.

@mattrobball mattrobball added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. and removed awaiting-author A reviewer has asked the author a question or requested changes labels May 12, 2023
@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 12, 2023
bors bot pushed a commit that referenced this pull request May 12, 2023
@mattrobball @mo271 @ChrisHughes24
feat: port Topology.Category.Top.Limits.Pullbacks (#3802)
fb165b6 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Matthew Robert Ballard <100034030+mattrobball@users.noreply.github.com>
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
@bors
Copy link

bors bot commented May 12, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Topology.Category.Top.Limits.Pullbacks [Merged by Bors] - feat: port Topology.Category.Top.Limits.Pullbacks May 12, 2023
@bors bors bot closed this May 12, 2023
@bors bors bot deleted the port/Topology.Category.Top.Limits.Pullbacks branch May 12, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mattrobball @semorrison @ChrisHughes24 @jcommelin @mo271