Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Order.Category.FinPartOrd #3831

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat: port Order.Category.FinPartOrd #3831

wants to merge 5 commits into from

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented May 7, 2023

Open in Gitpod

@int-y1 int-y1 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels May 7, 2023
@int-y1 int-y1 changed the title feat: port Order.Category.FinPartOrd feat: port Order.Category.FinPartOrdCat May 7, 2023
@int-y1
Copy link
Collaborator Author

int-y1 commented May 7, 2023 •
edited by Ruben-VandeVelde

todo:

  • coe_toPartOrdCat synTaut linter

@int-y1 int-y1 added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels May 7, 2023
@semorrison semorrison added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. labels May 15, 2023
Ruben-VandeVelde and others added 5 commits May 26, 2023 15:47
@Ruben-VandeVelde
feat: port Order.Category.FinPartOrd
17c8457
@Ruben-VandeVelde
Initial file copy from mathport
e7dc53b
@Ruben-VandeVelde
automated fixes
dd7db42 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@int-y1 @YaelDillies @Ruben-VandeVelde
fixes
e7c4520 
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@Ruben-VandeVelde
syntaut
a61805c
@Ruben-VandeVelde Ruben-VandeVelde changed the title feat: port Order.Category.FinPartOrdCat feat: port Order.Category.FinPartOrd May 26, 2023
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels May 26, 2023
jcommelin
jcommelin reviewed May 26, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 26, 2023
bors bot pushed a commit that referenced this pull request May 26, 2023
@Ruben-VandeVelde @int-y1
feat: port Order.Category.FinPartOrd (#3831)
8828d20 
Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
@bors
Copy link

bors bot commented May 26, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Order.Category.FinPartOrd [Merged by Bors] - feat: port Order.Category.FinPartOrd May 26, 2023
@bors bors bot closed this May 26, 2023
@bors bors bot deleted the port/Order.Category.FinPartOrd branch May 26, 2023 15:29
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@Ruben-VandeVelde @int-y1 @qawbecrdtey
feat: port Order.Category.FinPartOrd (leanprover-community#3831)
02954b8 
Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@int-y1 @jcommelin @semorrison @Ruben-VandeVelde