Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port CategoryTheory.Abelian.Pseudoelements #3843

Closed
wants to merge 15 commits into from

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented May 7, 2023


Open in Gitpod

@int-y1 int-y1 added the mathlib-port This is a port of a theory file from mathlib. label May 7, 2023
@int-y1
Copy link
Collaborator Author

int-y1 commented May 7, 2023

todo:

  • problem with attribute [ext] on zero_morphism_ext and zero_morphism_ext'

@int-y1 int-y1 added the help-wanted The author needs attention to resolve issues label May 7, 2023
@semorrison
Copy link
Contributor

@int-y1, we've become more strict about the shape of ext lemmas, for better or worse, so the right thing to do here is remove them.

I've also switched all the pseudoZeros back to 0. In Lean 4 this instance has become safe as a global instance, because the coe_sort is replaced by Pseudoelement, so the instance is structural.

@semorrison semorrison added awaiting-review The author would like community review of the PR awaiting-CI and removed help-wanted The author needs attention to resolve issues labels May 10, 2023
@semorrison
Copy link
Contributor

If this looks good to you, please merge. Otherwise set back to awaiting-review or help-wanted as appropriate.

bors d+

@bors
Copy link

bors bot commented May 10, 2023

✌️ int-y1 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR awaiting-CI labels May 10, 2023
@semorrison
Copy link
Contributor

@int-y1, I started the next file, at #3882, please feel free to hack on it / adopt. :-)

@int-y1
Copy link
Collaborator Author

int-y1 commented May 10, 2023

bors r+

bors bot pushed a commit that referenced this pull request May 10, 2023
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
@bors
Copy link

bors bot commented May 10, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port CategoryTheory.Abelian.Pseudoelements [Merged by Bors] - feat: port CategoryTheory.Abelian.Pseudoelements May 10, 2023
@bors bors bot closed this May 10, 2023
@bors bors bot deleted the port/CategoryTheory.Abelian.Pseudoelements branch May 10, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants