Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: drop some unnecessary imports #3869

Closed
wants to merge 2 commits into from

Conversation

hrmacbeth
Copy link
Member


Open in Gitpod

@hrmacbeth hrmacbeth added the awaiting-review The author would like community review of the PR label May 9, 2023
@semorrison
Copy link
Contributor

I think the actual problem here is that Riccardo put the wrong imports in Mathlib.Algebra.Order.Hom.Basic when porting!

@semorrison
Copy link
Contributor

i.e. the correct fix is to revert your change, and replace the import block in Mathlib.Algebra.Order.Hom.Basic with

import Mathlib.Algebra.GroupPower.Order

(I identified this by trying to backport.)

@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels May 9, 2023
@hrmacbeth hrmacbeth added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels May 10, 2023
@semorrison
Copy link
Contributor

Please merge if CI accepts leanprover-community/mathlib#18978!

bors d+

@bors
Copy link

bors bot commented May 10, 2023

✌️ hrmacbeth can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels May 10, 2023
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request May 10, 2023
This is just a CI verification backport of leanprover-community/mathlib4#3869. Feel free to either close or merge!



Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder that we should not update the SHA for this file in this PR, as there are other changes which would need forward-porting first.

@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label May 10, 2023
bors bot pushed a commit that referenced this pull request May 10, 2023
@bors
Copy link

bors bot commented May 10, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: drop some unnecessary imports [Merged by Bors] - chore: drop some unnecessary imports May 10, 2023
@bors bors bot closed this May 10, 2023
@bors bors bot deleted the streamline-imports branch May 10, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants