Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Topology.Category.Compactum #3872

Closed
wants to merge 12 commits into from
Closed

[Merged by Bors] - feat: port Topology.Category.Compactum #3872

wants to merge 12 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented May 9, 2023

Open in Gitpod

mo271 added 4 commits May 9, 2023 20:35
@mo271
feat: port Topology.Category.Compactum
d411971
@mo271
Initial file copy from mathport
ae6b2b6
@mo271
automated fixes
ed2d837 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@mo271
starting
00219d7
@mo271 mo271 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels May 9, 2023
@mo271 mo271 removed the WIP Work in progress label May 9, 2023
@mo271 mo271 added the help-wanted The author needs attention to resolve issues label May 10, 2023
@mo271
Copy link
Collaborator Author

mo271 commented May 10, 2023 •
edited by mattrobball

What's left:

  • computability issues (see porting notes)
  • Failing to synthesize instance TopologicalSpace X.A for Compactum X (and a few consequences of that)
  • Manual naming, i.e. continuous_of_hom should probably be continuousOfHom and names in comments

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label May 10, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label May 10, 2023
@mo271
Copy link
Collaborator Author

mo271 commented May 11, 2023

https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/!4.233872.20Topology.2ECategory.2ECompactum

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label May 16, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label May 18, 2023
@mattrobball mattrobball added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Jun 7, 2023
@jcommelin
Copy link
Member

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 8, 2023
bors bot pushed a commit that referenced this pull request Jun 8, 2023
@mo271 @mattrobball @jcommelin
feat: port Topology.Category.Compactum (#3872)
3d02c7d 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Matthew Ballard <matt@mrb.email>
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Jun 8, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Topology.Category.Compactum [Merged by Bors] - feat: port Topology.Category.Compactum Jun 8, 2023
@bors bors bot closed this Jun 8, 2023
@bors bors bot deleted the port/Topology.Category.Compactum branch June 8, 2023 04:34
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@mo271 @mattrobball
@jcommelin @qawbecrdtey
feat: port Topology.Category.Compactum (leanprover-community#3872)
733cf0d 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Matthew Ballard <matt@mrb.email>
Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mo271 @jcommelin @semorrison @mattrobball