Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ring tactic fix #39

Merged
merged 42 commits into from
Aug 18, 2021
Merged
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
26ea774
aligned tactic names to mathport
Jul 27, 2021
76df513
added byContra tactic
Jul 27, 2021
02bc2aa
added guardExprEq guardTarget guardHyp
Jul 27, 2021
ead4544
added introv
Jul 27, 2021
d664e84
Update Mathlib/Tactic/Basic.lean
AurelienSaue Jul 27, 2021
1162ace
Update Mathlib/Tactic/Basic.lean
AurelienSaue Jul 27, 2021
4859e82
added exacts
Jul 27, 2021
d95a24a
Merge branch 'master' of https://github.com/AurelienSaue/mathlib4
Jul 27, 2021
1cf3d37
use of elab and examples
Jul 29, 2021
db7dbaf
matchTarget
Jul 29, 2021
679185e
byContra all cases
Jul 29, 2021
4854a7c
sorry & iterate
Aug 3, 2021
579951b
fix : get to build
Aug 3, 2021
dd584b2
fix : get to build
Aug 3, 2021
ed66f1d
fix : get to build 3
Aug 3, 2021
02d7bac
Merge branch 'leanprover-community:master' into master
AurelienSaue Aug 3, 2021
47c1a01
fix : alpha eq in guardHyp but consuming mdata
Aug 3, 2021
8d4e0c4
feat : repeat' tactic
Aug 3, 2021
3a4aaee
feat : anyGoals tactic
Aug 3, 2021
ec8d52f
feat(Algebra/Group/Defs): Monoid lemmas
AurelienSaue Aug 5, 2021
9ff0a47
feat(Tactic/Ring): starting ring
AurelienSaue Aug 5, 2021
d243124
fix: fixed normNum
Aug 9, 2021
1adce92
fix : compatibility Numeric.ofNat with One.one and Zero.zero
Aug 9, 2021
9df0274
fix : removed print
Aug 9, 2021
be4933c
fix: fixed normNum
Aug 9, 2021
f560ea8
feat: ring with only additions and one variable
Aug 9, 2021
eadfe7d
feat: ring tactic furnctional for addition and multiplication
Aug 10, 2021
fe76071
feat(Algebra) : more lemmas
Aug 11, 2021
a93a28e
feat (Tactic/NormNum) : normNum exponentiation
Aug 11, 2021
c278662
feat (Tactic/Ring) : exponentiation for ring
Aug 11, 2021
b2629bf
Merge branch 'leanprover-community:master' into ring
AurelienSaue Aug 11, 2021
7a04693
fix : updated with new version of mkNatLit
Aug 11, 2021
8bb225e
fix : import ring
Aug 11, 2021
e9a385d
Merge branch 'leanprover-community:master' into ring
AurelienSaue Aug 12, 2021
e56b0a8
chore : update to newer lean version
Aug 12, 2021
f695682
Merge branch 'master' into ring
AurelienSaue Aug 16, 2021
4de47ac
doc (Tactic/Ring) : add author
Aug 16, 2021
e9e05b5
fix(Algebra/Group/Defs) : Monoid.npow
Aug 16, 2021
3911810
chore(Tactic/Ring) : updated to new lean version
Aug 16, 2021
e0d9dfa
Merge branch 'leanprover-community:master' into ring
AurelienSaue Aug 17, 2021
6ac501e
fix(Tactic/Ring) : fixed issue with constant multiplication
Aug 18, 2021
1d67759
Merge branch 'leanprover-community:master' into ring
AurelienSaue Aug 18, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Mathlib/Tactic/Ring.lean
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,7 @@ by simp [h₂.symm, h₁.symm, horner, add_mul, @mul_right_comm α _]
/-- Evaluate `k * a` where `k` is a rational numeral and `a` is in normal form. -/
def evalConstMul (k : Expr × ℕ) : HornerExpr → RingM (HornerExpr × Expr)
| (const e coeff) => do
let e' ← mkRawNatLit (k.2 * coeff)
let p ← mkEqRefl e'
let (e', p) ← NormNum.eval $ ← mkMul k.1 e
return (const e' (k.2 * coeff), p)
| (xadd e a x n b) => do
let (a', h₁) ← evalConstMul k a
Expand Down