Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Analysis.NormedSpace.OperatorNorm #3903

Closed
wants to merge 22 commits into from
Closed

[Merged by Bors] - feat: port Analysis.NormedSpace.OperatorNorm #3903

wants to merge 22 commits into from

Conversation

semorrison
Copy link
Contributor

@semorrison semorrison commented May 11, 2023 •
edited by Parcly-Taxel

This is the pushout of #3708 and the reenableeta branch #3414, to verify that even though #3708 is taking over 6 hours in CI, it is no problem with reenableeta.

Open in Gitpod

@semorrison semorrison changed the title feat: port Analysis.NormedSpace.OperatorNorm, with reenableeta feat: port Analysis.NormedSpace.OperatorNorm May 16, 2023
@semorrison semorrison marked this pull request as ready for review May 16, 2023 03:57
@semorrison semorrison added blocked-by-other-PR This PR depends on another PR which is still in the queue. awaiting-review The author would like community review of the PR awaiting-CI labels May 16, 2023
@semorrison semorrison mentioned this pull request May 16, 2023
Closed
@semorrison semorrison added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. blocked-by-other-PR This PR depends on another PR which is still in the queue. labels May 16, 2023
@semorrison
Copy link
Contributor Author

This PR/issue depends on:

@semorrison semorrison added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. labels May 16, 2023
@jcommelin
Copy link
Member

Can we rewrite the history on this PR, to make it easier to review? I would like to get the diff between mathport output and the HEAD of the PR.

@Parcly-Taxel
Copy link
Collaborator

Parcly-Taxel commented May 17, 2023 •
edited

I'm gonna try…

@Ruben-VandeVelde
Copy link
Collaborator

Can we rewrite the history on this PR, to make it easier to review? I would like to get the diff between mathport output and the HEAD of the PR.

Done.

@Ruben-VandeVelde Ruben-VandeVelde added the mathlib-port This is a port of a theory file from mathlib. label May 17, 2023
@Parcly-Taxel
Clean up
73cf2e0 
and also compress the final steps of `prodMapL`
jcommelin
jcommelin reviewed May 17, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for cleaning up the git history! And for all the valiant work on this monster PR!

Mathlib/Analysis/NormedSpace/OperatorNorm.lean
Comment on lines +471 to +472
-- Porting FIXME: replacing `(algebra : Algebra 𝕜 (E →L[𝕜] E))` with
-- just `algebra` below causes a massive timeout.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still true?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's either this or set_option maxHeartbeats 2000000 (2 million). 1 million is not enough.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming!

Mathlib/Analysis/NormedSpace/OperatorNorm.lean
Comment on lines +811 to +812
set_option maxHeartbeats 300000 in
set_option synthInstance.maxHeartbeats 25000 in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that all heartbeat settings in the file as it stands now are needed; the declaration here suffers from both a defeq timeout and a synth-instance timeout, so both set_options are needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming!

Mathlib/Analysis/NormedSpace/OperatorNorm.lean Show resolved Hide resolved
Mathlib/Analysis/NormedSpace/OperatorNorm.lean Show resolved Hide resolved
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 17, 2023
bors bot pushed a commit that referenced this pull request May 17, 2023
@semorrison @Ruben-VandeVelde
@Parcly-Taxel @arienmalec @jcommelin @collares
feat: port Analysis.NormedSpace.OperatorNorm (#3903)
9ab4016 


Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Co-authored-by: Arien Malec <arien.malec@gmail.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
Co-authored-by: Mauricio Collares <mauricio@collares.org>
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented May 17, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Analysis.NormedSpace.OperatorNorm [Merged by Bors] - feat: port Analysis.NormedSpace.OperatorNorm May 17, 2023
@bors bors bot closed this May 17, 2023
@bors bors bot deleted the reenableeta_OperatorNorm branch May 17, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

@Parcly-Taxel Parcly-Taxel Parcly-Taxel left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@semorrison @jcommelin @Parcly-Taxel @Ruben-VandeVelde @arienmalec @collares