[Merged by Bors] - feat: port Algebra.Category.Group.Injective #3908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mattrobball
commented
May 11, 2023
•
mattrobball
commented
- depends on: [Merged by Bors] - feat: port Algebra.Module.Injective #3873
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
commit 3ff5641 Author: Matthew Ballard <matt@mrb.email> Date: Wed May 10 10:39:49 2023 -0400 misc commit a148357 Author: Matthew Ballard <matt@mrb.email> Date: Wed May 10 10:31:51 2023 -0400 capitalize import file commit 6aab7dd Author: Matthew Ballard <matt@mrb.email> Date: Wed May 10 10:29:52 2023 -0400 lint commit 9d3e55d Author: Matthew Ballard <matt@mrb.email> Date: Wed May 10 10:27:38 2023 -0400 fix last errors, rename commit 5aa6268 Author: Matthew Ballard <matt@mrb.email> Date: Tue May 9 17:06:18 2023 -0400 fix more commit df92a44 Author: Matthew Ballard <matt@mrb.email> Date: Tue May 9 14:33:09 2023 -0400 automated fixes Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean commit 88161ad Author: Matthew Ballard <matt@mrb.email> Date: Tue May 9 14:33:09 2023 -0400 Initial file copy from mathport commit c7d31f2 Author: Matthew Ballard <matt@mrb.email> Date: Tue May 9 14:33:09 2023 -0400 feat: port Algebra.Module.Injective
semorrison
removed
the
blocked-by-math-PR
|
This PR/issue depends on:
|
mattrobball
added
the
awaiting-review
jcommelin
reviewed
May 12, 2023
| ext | ||
| convert FunLike.congr_fun (injective.comp_factor_thru G F) x } | ||
| convert map_zero (M := Y) (N := A) (F := Y →+ A) _ | ||
| -- Porting note: hell of non-defeq instances; somehow this worked |
There was a problem hiding this comment.
Will this improve after Scott's refactor of concrete categories?
There was a problem hiding this comment.
Alas, no. The problem is that M : ModuleCat \Z has the two fields isCommAddGroup and isModule so we immediately get a non-defeq diamond with isCommAddGroup.intModule and isModule. The ML3 version is clearly doing some work to dance around this. Things don't translate directly to ML4.
But it does look like #3900 let me drop a re-declaration of an instance.
Or at least I think that is why
semorrison
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.