Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Data.Nat.Choose.Basic: Register a faster implementation #3915

Closed
wants to merge 4 commits into from

Conversation

Copy link
Collaborator

@mattrobball mattrobball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way, way faster. Nice!

@nomeata You may want to add the awaiting-review tag and probably the new-feature tag if you want it be reviewed for merging.

@nomeata nomeata added awaiting-review The author would like community review of the PR new-feature Add features not present in Mathlib 3 labels Jun 17, 2023
@kmill
Copy link
Contributor

kmill commented Jun 29, 2023

Thanks!

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 29, 2023
bors bot pushed a commit that referenced this pull request Jun 29, 2023
Co-authored-by: Kyle Miller <kmill31415@gmail.com>
@bors
Copy link

bors bot commented Jun 29, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title Data.Nat.Choose.Basic: Register a faster implementation [Merged by Bors] - Data.Nat.Choose.Basic: Register a faster implementation Jun 29, 2023
@bors bors bot closed this Jun 29, 2023
@bors bors bot deleted the joachim/fast-choose branch June 29, 2023 23:57
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
Co-authored-by: Kyle Miller <kmill31415@gmail.com>
nomeata added a commit to nomeata/rerolling-sixes that referenced this pull request Jul 24, 2023
semorrison pushed a commit that referenced this pull request Aug 14, 2023
Co-authored-by: Kyle Miller <kmill31415@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature Add features not present in Mathlib 3 ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants