-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: port CategoryTheory.Sites.Canonical #3936
Conversation
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
convert this using 1 | ||
simp | ||
-- porting note: without this strange `change _ = _`, the `trans` refused to work | ||
change _ = _ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is due to a known bug in trans
that should be fixed in #3768
@joelriou what are next steps here? |
@Ruben-VandeVelde As #3768 was merged, I could do a few fixes. This should be ready for review when CI finishes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
It compiles, but there is a
simp
issue discussed at https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/simp.20regression/near/357814659