Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port GroupTheory.NielsenSchreier #3981

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - feat: port GroupTheory.NielsenSchreier #3981

wants to merge 11 commits into from

Conversation

yuma-mizuno
Copy link
Collaborator

Open in Gitpod

@yuma-mizuno
feat: port GroupTheory.NielsenSchreier
a54df12
@yuma-mizuno
Initial file copy from mathport
1ffe39f
@yuma-mizuno
automated fixes
9cd2b3c 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@yuma-mizuno yuma-mizuno added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels May 14, 2023
@yuma-mizuno yuma-mizuno added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. and removed WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels May 15, 2023
@jcommelin
Copy link
Member

bors d+

@bors
Copy link

bors bot commented May 15, 2023

✌️ yuma-mizuno can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels May 15, 2023
@yuma-mizuno @jcommelin
Update Mathlib/GroupTheory/NielsenSchreier.lean
e6b07fc 
Co-authored-by: Johan Commelin <johan@commelin.net>
@yuma-mizuno
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request May 15, 2023
@yuma-mizuno
feat: port GroupTheory.NielsenSchreier (#3981)
ace842a
@yuma-mizuno
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request May 15, 2023
@yuma-mizuno
feat: port GroupTheory.NielsenSchreier (#3981)
a39a8f5
@bors
Copy link

bors bot commented May 15, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port GroupTheory.NielsenSchreier [Merged by Bors] - feat: port GroupTheory.NielsenSchreier May 15, 2023
@bors bors bot closed this May 15, 2023
@bors bors bot deleted the port/GroupTheory.NielsenSchreier branch May 15, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yuma-mizuno @jcommelin