[Merged by Bors] - feat: port Topology.Gluing #3987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruben-VandeVelde
added
please-adopt
mathlib-port
adomani
added
help-wanted
|
There are just a small number of sorries left and a couple of uses of the Any help is greatly appreciated, thanks! |
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
Ruben-VandeVelde
force-pushed
the
port/Topology.Gluing
branch
from
cd3980d
to
2d0fdb6
Compare
|
Stopping now; three errors left |
jjaassoonn
added
awaiting-review
semorrison
reviewed
Jun 14, 2023
semorrison
reviewed
Jun 14, 2023
semorrison
reviewed
Jun 14, 2023
semorrison
reviewed
Jun 14, 2023
semorrison
reviewed
Jun 14, 2023
semorrison
reviewed
Jun 14, 2023
Mathlib/Topology/Gluing.lean
Outdated
| t : ∀ i j, (Opens.toTopCat _).obj (V i j) ⟶ (Opens.toTopCat _).obj (V j i) | ||
| V_id : ∀ i, V i i = ⊤ | ||
| t_id : ∀ i, ⇑(t i i) = id | ||
| -- porting note: was vv `@coe (V j i) (U j) _ (t i j x) ∈ V j k` |
There was a problem hiding this comment.
Why is this indented so far?
There was a problem hiding this comment.
I wonder if (((↑) : (V j i) → (U j)) (t i j x)) should be (t I j x).1 instead
semorrison
reviewed
Jun 14, 2023
semorrison
reviewed
Jun 14, 2023
semorrison
reviewed
Jun 14, 2023
Co-authored-by: Scott Morrison <scott@tqft.net>
semorrison
reviewed
Jun 14, 2023
semorrison
reviewed
Jun 14, 2023
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
Co-authored-by: Scott Morrison <scott@tqft.net> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: adomani <adomani@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
alexkeizer
pushed a commit
that referenced
this pull request
Jun 22, 2023
Co-authored-by: Scott Morrison <scott@tqft.net> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: adomani <adomani@gmail.com>
semorrison
added a commit
that referenced
this pull request
Jun 25, 2023
Co-authored-by: Scott Morrison <scott@tqft.net> Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: adomani <adomani@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This triggers a stack overflow in the compiler.