Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Algebra.Homology.Opposite #3998

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - feat: port Algebra.Homology.Opposite #3998

wants to merge 8 commits into from

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented May 15, 2023 •
edited by mattrobball

todo:

  • theorem imageToKernel_op fix proof
  • def homologyOp fix proof
  • def homologyUnop fix proof

Open in Gitpod

@int-y1
feat: port Algebra.Homology.Opposite
ab39811
@int-y1
Initial file copy from mathport
fdf7fd2
@int-y1
automated fixes
2039fa7 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@int-y1
fix most
c1c1169
@int-y1
clean up
4dc6dcd
@int-y1 int-y1 added help-wanted The author needs attention to resolve issues mathlib-port This is a port of a theory file from mathlib. labels May 15, 2023
@mattrobball mattrobball added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels May 16, 2023
jcommelin
jcommelin reviewed May 17, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 17, 2023
bors bot pushed a commit that referenced this pull request May 17, 2023
@int-y1 @mo271 @mattrobball
feat: port Algebra.Homology.Opposite (#3998)
4cb84b7 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Matthew Ballard <matt@mrb.email>
@bors
Copy link

bors bot commented May 17, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Algebra.Homology.Opposite [Merged by Bors] - feat: port Algebra.Homology.Opposite May 17, 2023
@bors bors bot closed this May 17, 2023
@bors bors bot deleted the port/Algebra.Homology.Opposite branch May 17, 2023 06:40
@Parcly-Taxel Parcly-Taxel mentioned this pull request May 17, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@int-y1 @jcommelin @semorrison @mattrobball @mo271