Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Analysis.SpecialFunctions.Trigonometric.Basic #4015

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: port Analysis.SpecialFunctions.Trigonometric.Basic #4015

wants to merge 7 commits into from

Conversation

pechersky
Copy link
Collaborator

@pechersky pechersky commented May 16, 2023 •
edited by Ruben-VandeVelde

Open in Gitpod

@pechersky
feat: port Analysis.SpecialFunctions.Trigonometric.Basic
6ef95d4
@pechersky
Initial file copy from mathport
5cbeaf7
@pechersky
automated fixes
67a4fc9 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Parcly-Taxel
Copy link
Collaborator

I'm going to fix most of the errors in this file right now. There are just two kinds of failures remaining: four continuity failures and five convert failures.

@urkud
Copy link
Member

urkud commented May 16, 2023

I'm going to fix lint errors

@urkud
Copy link
Member

urkud commented May 16, 2023

@pechersky Is it ready for review? If yes, then adjust the labels, please.

@pechersky pechersky added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels May 16, 2023
@pechersky pechersky mentioned this pull request May 16, 2023
Closed
1 task
urkud
urkud reviewed May 16, 2023
View reviewed changes
Mathlib/Topology/Algebra/Group/Basic.lean
@@ -178,6 +178,8 @@ over `M`, for example, is obtained by requiring the instances `AddGroup M` and
class ContinuousNeg (G : Type u) [TopologicalSpace G] [Neg G] : Prop where
continuous_neg : Continuous fun a : G => -a
#align has_continuous_neg ContinuousNeg
-- Porting note: added
attribute [continuity] ContinuousNeg.continuous_neg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you understand why continuity on Continuous.neg is not enough?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is because aesop ends up going using this instead of Continuous.neg continuous_id. In particular, the inner term in exp (-x) looks like just a Neg.neg application as opposed to a Neg.neg \comp f.

@pechersky pechersky mentioned this pull request May 17, 2023
Closed
1 task
jcommelin
jcommelin reviewed May 17, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 17, 2023
bors bot pushed a commit that referenced this pull request May 17, 2023
@pechersky @Parcly-Taxel
@Ruben-VandeVelde @urkud
feat: port Analysis.SpecialFunctions.Trigonometric.Basic (#4015)
882c98b 



Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@bors
Copy link

bors bot commented May 17, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Analysis.SpecialFunctions.Trigonometric.Basic [Merged by Bors] - feat: port Analysis.SpecialFunctions.Trigonometric.Basic May 17, 2023
@bors bors bot closed this May 17, 2023
@bors bors bot deleted the port/Analysis.SpecialFunctions.Trigonometric.Basic branch May 17, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urkud urkud urkud left review comments

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pechersky @Parcly-Taxel @urkud @jcommelin @semorrison @Ruben-VandeVelde