Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat port RingTheory.JacobsonIdeal #4061

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat port RingTheory.JacobsonIdeal #4061

wants to merge 6 commits into from

Conversation

jjaassoonn
Copy link
Collaborator

@jjaassoonn jjaassoonn commented May 18, 2023 •
edited

Open in Gitpod

@jjaassoonn
feat: port RingTheory.JacobsonIdeal
4e41034
@jjaassoonn
Initial file copy from mathport
871da09
@jjaassoonn
automated fixes
83b8f27 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@jjaassoonn
it compiles
b47e1d4
@jjaassoonn jjaassoonn added mathlib-port This is a port of a theory file from mathlib. awaiting-review The author would like community review of the PR awaiting-CI labels May 18, 2023
@jjaassoonn jjaassoonn changed the title Port/RingTheory.JacobsonIdeal feat Port/RingTheory.JacobsonIdeal May 18, 2023
@jjaassoonn jjaassoonn changed the title feat Port/RingTheory.JacobsonIdeal feat port RingTheory.JacobsonIdeal May 18, 2023
jcommelin
jcommelin approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 18, 2023
bors bot pushed a commit that referenced this pull request May 18, 2023
@jjaassoonn
feat port RingTheory.JacobsonIdeal (#4061)
a3ae6e9
@bors
Copy link

bors bot commented May 18, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat port RingTheory.JacobsonIdeal [Merged by Bors] - feat port RingTheory.JacobsonIdeal May 18, 2023
@bors bors bot closed this May 18, 2023
@bors bors bot deleted the port/RingTheory.JacobsonIdeal branch May 18, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jjaassoonn @jcommelin @semorrison