Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore Set/UnionLift: generalize to Sort #4071

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - chore Set/UnionLift: generalize to Sort #4071

wants to merge 4 commits into from

Conversation

ChrisHughes24
Copy link
Member

@ChrisHughes24 ChrisHughes24 commented May 18, 2023 •
edited by Komyyy

@ChrisHughes24 ChrisHughes24 added the awaiting-review The author would like community review of the PR label May 18, 2023
@ChrisHughes24 ChrisHughes24 mentioned this pull request May 18, 2023
Closed
@semorrison semorrison added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label May 18, 2023
@ChrisHughes24 ChrisHughes24 mentioned this pull request May 18, 2023
Closed
1 task
@ChrisHughes24 ChrisHughes24 added needs-mathlib-SHA easy < 20s of review time. See the lifecycle page for guidelines. labels May 18, 2023
@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label May 18, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@eric-wieser eric-wieser added the mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged label May 18, 2023
@Komyyy
Copy link
Collaborator

Komyyy commented May 19, 2023

I've updated SHA.

@Komyyy Komyyy mentioned this pull request May 19, 2023
Closed
eric-wieser
eric-wieser approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Thanks!

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 19, 2023
bors bot pushed a commit that referenced this pull request May 19, 2023
@ChrisHughes24 @Komyyy
chore Set/UnionLift: generalize to Sort (#4071)
83998c1 
Co-authored-by: Komyyy <pol_tta@outlook.jp>
@bors
Copy link

bors bot commented May 19, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore Set/UnionLift: generalize to Sort [Merged by Bors] - chore Set/UnionLift: generalize to Sort May 19, 2023
@bors bors bot closed this May 19, 2023
@bors bors bot deleted the SortUnionLift branch May 19, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ChrisHughes24 @semorrison @Komyyy @eric-wieser