Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port Topology.ContinuousFunction.Bounded #4075

Closed
wants to merge 13 commits into from

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented May 18, 2023


todo:

  • instance CompleteSpace, find an alternative to by mono*
    A: Used a couple of add_le_adds. It would be good if automation helped, but it didn't!
  • instance SeminormedRing (α →ᵇ R), error
    A: Gave explicitly the Ring instance that was proven earlier: why did it not synthesize it on its own?
  • instance NormedRing (α →ᵇ R), error
    A: Gave explicitly the Ring instance that was proven earlier: why did it not synthesize it on its own?
  • instance NormedAlgebra 𝕜 (α →ᵇ γ), synthesized type class instance is not definitionally equal to expression inferred by typing rules
    A: Gave explicitly the Algebra instance that was proven earlier: why did it not synthesize it on its own?

Open in Gitpod

Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@int-y1 int-y1 added help-wanted The author needs attention to resolve issues WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels May 18, 2023
@int-y1
Copy link
Collaborator Author

int-y1 commented May 19, 2023

I started working on this

@int-y1
Copy link
Collaborator Author

int-y1 commented May 19, 2023

I stopped working on this

@adomani adomani added awaiting-CI and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels May 20, 2023
@adomani
Copy link
Collaborator

adomani commented May 20, 2023

See this Zulip discussion, regarding commit f073782 and whether it is a good or bad idea to guide Lean into providing the missing instances.

Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

Mathlib/Topology/ContinuousFunction/Bounded.lean Outdated Show resolved Hide resolved
Mathlib/Topology/ContinuousFunction/Bounded.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented May 21, 2023

✌️ int-y1 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@int-y1
Copy link
Collaborator Author

int-y1 commented May 21, 2023

bors r+

bors bot pushed a commit that referenced this pull request May 21, 2023
Co-authored-by: adomani <adomani@gmail.com>
@bors
Copy link

bors bot commented May 21, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Topology.ContinuousFunction.Bounded [Merged by Bors] - feat: port Topology.ContinuousFunction.Bounded May 21, 2023
@bors bors bot closed this May 21, 2023
@bors bors bot deleted the port/Topology.ContinuousFunction.Bounded branch May 21, 2023 22:16
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants