Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Algebra.Category.Mon.FilteredColimits #4094

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - feat: port Algebra.Category.Mon.FilteredColimits #4094

wants to merge 11 commits into from

Conversation

jjaassoonn
Copy link
Collaborator

Open in Gitpod

@jjaassoonn
feat: port Algebra.Category.Mon.FilteredColimits
0f763a2
@jjaassoonn
Initial file copy from mathport
b970158
@jjaassoonn
automated fixes
1182b4d 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@jjaassoonn jjaassoonn added the mathlib-port This is a port of a theory file from mathlib. label May 18, 2023
@jjaassoonn jjaassoonn added the help-wanted The author needs attention to resolve issues label May 19, 2023
@jjaassoonn jjaassoonn marked this pull request as ready for review May 19, 2023 17:48
@jjaassoonn jjaassoonn added the awaiting-author A reviewer has asked the author a question or requested changes label May 20, 2023
@jjaassoonn jjaassoonn added awaiting-CI awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues awaiting-author A reviewer has asked the author a question or requested changes labels May 20, 2023
ChrisHughes24
ChrisHughes24 reviewed May 20, 2023
View reviewed changes
Mathlib/Algebra/Category/Mon/FilteredColimits.lean Outdated

-- Porting note : need to add `FunLike` instance manually
@[to_additive]
noncomputable local instance FunLike_instance' (t : Cocone.{v, max v u, v} F) :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these only local instances? What is going on here, why can't they be synthesised?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect Lean don't know the arrows in category of monoids are just monoid homomorphisms. Lean knows that homomorphisms are FunLike but can't see that arrows are FunLike unless it is expanded manually.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stated FunLike instance for arrows in (Comm)MonCatin MonCat file, so local instances no longer needed

@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 21, 2023
bors bot pushed a commit that referenced this pull request May 21, 2023
@jjaassoonn @semorrison
feat: port Algebra.Category.Mon.FilteredColimits (#4094)
357f282 
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented May 21, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Algebra.Category.Mon.FilteredColimits [Merged by Bors] - feat: port Algebra.Category.Mon.FilteredColimits May 21, 2023
@bors bors bot closed this May 21, 2023
@bors bors bot deleted the port/Algebra.Category.Mon.FilteredColimits branch May 21, 2023 15:37
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@jjaassoonn @semorrison @qawbecrdtey
feat: port Algebra.Category.Mon.FilteredColimits (leanprover-communit…
2126460 
…y#4094)

Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisHughes24 ChrisHughes24 Awaiting requested review from ChrisHughes24

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jjaassoonn @ChrisHughes24 @semorrison