Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: partially forward-port leanprover-community/mathlib#19037 #4102

Closed
wants to merge 1 commit into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented May 19, 2023


Open in Gitpod

Note this change blocks the port of topology.algebra.module.star, which is top of the porting dashboard.

There is no mathport output to compare this against yet, but also the change is rather easy to translate manually from Lean 3 to Lean 4.

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged awaiting-CI labels May 19, 2023
@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 19, 2023
@bors
Copy link

bors bot commented May 19, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: partially forward-port leanprover-community/mathlib#19037 [Merged by Bors] - chore: partially forward-port leanprover-community/mathlib#19037 May 19, 2023
@bors bors bot closed this May 19, 2023
@bors bors bot deleted the forward-port-19037 branch May 19, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants