Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port RingTheory.Artinian #4104

Closed
wants to merge 9 commits into from

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented May 19, 2023


todo:

  • (optional) class IsArtinian understand this comment: "infer kinds are unsupported in Lean 4"
  • instance isArtinian_pi failed to synthesize instance
  • theorem isArtinian_of_fG_of_artinian application type mismatch at isArtinian_of_surjective

Open in Gitpod

Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@int-y1 int-y1 added help-wanted The author needs attention to resolve issues mathlib-port This is a port of a theory file from mathlib. labels May 19, 2023
@ChrisHughes24
Copy link
Member

The inferkinds error is to do with the [] in the Lean3 definition. It makes some stuff implicit or explicit, but I can't check what it does because I can't install mathlibtools right now for some reason.

class is_artinian (R M) [semiring R] [add_comm_monoid M] [module R M] : Prop :=
(well_founded_submodule_lt [] : well_founded ((<) : submodule R M → submodule R M → Prop))

@int-y1
Copy link
Collaborator Author

int-y1 commented May 21, 2023

The type in Lean 3 is:

is_artinian.well_founded_submodule_lt : ∀ (R : Type u_1) (M : Type u_3) [_inst_1 : semiring R] [_inst_2 : add_comm_monoid M] [_inst_3 : module R M] [self : is_artinian R M], well_founded has_lt.lt

Removing [] changed the type from (R) (M) to {R} {M}.

@ChrisHughes24 ChrisHughes24 added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels May 21, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 21, 2023
bors bot pushed a commit that referenced this pull request May 21, 2023
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
@bors
Copy link

bors bot commented May 22, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port RingTheory.Artinian [Merged by Bors] - feat: port RingTheory.Artinian May 22, 2023
@bors bors bot closed this May 22, 2023
@bors bors bot deleted the port/RingTheory.Artinian branch May 22, 2023 00:38
bors bot pushed a commit that referenced this pull request May 22, 2023
…#4218)

Removes an unneeded import that was accidentally included in #4104
bors bot pushed a commit that referenced this pull request May 22, 2023
…#4218)

Removes an unneeded import that was accidentally included in #4104
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
Co-authored-by: ChrisHughes24 <chrishughes24@gmail.com>
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants