Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Nat.Factorial.DoubleFactorial #4117

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat: port Data.Nat.Factorial.DoubleFactorial #4117

wants to merge 4 commits into from

Conversation

Parcly-Taxel
Copy link
Collaborator

Open in Gitpod

@Parcly-Taxel
feat: port Data.Nat.Factorial.DoubleFactorial
cd33963
@Parcly-Taxel
Initial file copy from mathport
c3d67af
@Parcly-Taxel
automated fixes
6a34a93 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Parcly-Taxel
Fix errors
6420b0a
@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. awaiting-CI labels May 19, 2023
@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 19, 2023
bors bot pushed a commit that referenced this pull request May 19, 2023
@Parcly-Taxel
feat: port Data.Nat.Factorial.DoubleFactorial (#4117)
8c878fe
@bors
Copy link

bors bot commented May 19, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Data.Nat.Factorial.DoubleFactorial [Merged by Bors] - feat: port Data.Nat.Factorial.DoubleFactorial May 19, 2023
@bors bors bot closed this May 19, 2023
@bors bors bot deleted the port/Data.Nat.Factorial.DoubleFactorial branch May 19, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Parcly-Taxel @ChrisHughes24