Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port RingTheory.Ideal.MinimalPrime #4146

Closed
wants to merge 23 commits into from
Closed

[Merged by Bors] - feat: port RingTheory.Ideal.MinimalPrime #4146

wants to merge 23 commits into from

Conversation

apurvnakade
Copy link
Collaborator

@apurvnakade apurvnakade commented May 20, 2023 •
edited

Please feel free to push changes to this branch.

Open in Gitpod

@apurvnakade
feat: port RingTheory.Ideal.MinimalPrime
0a5cedd
@apurvnakade
Initial file copy from mathport
ce6f32a
@apurvnakade
automated fixes
d007451 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@apurvnakade
Fix proof
ba82f62
@apurvnakade
Fix proof
1ac3acd
@apurvnakade apurvnakade added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels May 20, 2023
@apurvnakade apurvnakade changed the title Port/ring theory.ideal.minimal prime feat: port RingTheory/Ideal/MinimalPrime May 20, 2023
@apurvnakade apurvnakade changed the title feat: port RingTheory/Ideal/MinimalPrime feat: port RingTheory.Ideal.MinimalPrime May 20, 2023
@apurvnakade apurvnakade added the help-wanted The author needs attention to resolve issues label May 20, 2023
@apurvnakade apurvnakade removed the WIP Work in progress label May 20, 2023
@ChrisHughes24 ChrisHughes24 removed the help-wanted The author needs attention to resolve issues label May 21, 2023
@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label May 21, 2023
@bors
Copy link

bors bot commented May 21, 2023

Canceled.

@ChrisHughes24
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request May 21, 2023
@apurvnakade @int-y1
feat: port RingTheory.Ideal.MinimalPrime (#4146)
67e16b0 
Please feel free to push changes to this branch.



Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
@bors
Copy link

bors bot commented May 21, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port RingTheory.Ideal.MinimalPrime [Merged by Bors] - feat: port RingTheory.Ideal.MinimalPrime May 21, 2023
@bors bors bot closed this May 21, 2023
@bors bors bot deleted the port/RingTheory.Ideal.MinimalPrime branch May 21, 2023 16:04
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@apurvnakade @int-y1 @qawbecrdtey
feat: port RingTheory.Ideal.MinimalPrime (leanprover-community#4146)
5f5d386 
Please feel free to push changes to this branch.



Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@apurvnakade @ChrisHughes24 @int-y1