Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Topology.Sheaves.SheafCondition.Sites #4150

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat: port Topology.Sheaves.SheafCondition.Sites #4150

wants to merge 6 commits into from

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented May 20, 2023 •
edited

todo:

  • covering_presieve_eq_self got an error at ext (Z f)
  • isTerminalOfEmpty find an alternative to by tidy

Open in Gitpod

@int-y1
feat: port Topology.Sheaves.SheafCondition.Sites
7e560a8
@int-y1
Initial file copy from mathport
b151a84
@int-y1
automated fixes
54a3404 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@int-y1
fix + clean up
8ae0783
@int-y1 int-y1 added help-wanted The author needs attention to resolve issues mathlib-port This is a port of a theory file from mathlib. labels May 20, 2023
@int-y1 int-y1 added awaiting-review The author would like community review of the PR awaiting-CI and removed help-wanted The author needs attention to resolve issues labels May 21, 2023
@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 21, 2023
bors bot pushed a commit that referenced this pull request May 21, 2023
@int-y1
feat: port Topology.Sheaves.SheafCondition.Sites (#4150)
eeb99a4
@bors
Copy link

bors bot commented May 21, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Topology.Sheaves.SheafCondition.Sites [Merged by Bors] - feat: port Topology.Sheaves.SheafCondition.Sites May 21, 2023
@bors bors bot closed this May 21, 2023
@bors bors bot deleted the port/Topology.Sheaves.SheafCondition.Sites branch May 21, 2023 12:39
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@int-y1 @qawbecrdtey
feat: port Topology.Sheaves.SheafCondition.Sites (leanprover-communit…
e08f3f7 
…y#4150)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@int-y1 @ChrisHughes24