Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port RingTheory.DiscreteValuationRing.Basic #4156

Closed
wants to merge 13 commits into from
Closed

[Merged by Bors] - feat: port RingTheory.DiscreteValuationRing.Basic #4156

wants to merge 13 commits into from

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented May 21, 2023 •
edited
Loading

todo:

  • (optional) theorem addVal_*: these had type errors involving Multiplicative PartENatᵒᵈ and PartENat.
    i fixed these by adding : PartENat and show PartENat from to every theorem.
    find a more elegant approach
  • fix errors in addVal_*

Open in Gitpod

@int-y1
feat: port RingTheory.DiscreteValuationRing.Basic
eb158ec
@int-y1
Initial file copy from mathport
abdd7ba
@int-y1
automated fixes
7a508c1 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@int-y1
fix
78d49c0
@int-y1 int-y1 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels May 21, 2023
@int-y1 int-y1 added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels May 21, 2023
@ChrisHughes24
Copy link
Member

I fixed everything just by changing a CoeFun to a FunLike.

@ChrisHughes24 ChrisHughes24 added awaiting-review and removed help-wanted The author needs attention to resolve issues labels May 21, 2023
jcommelin
jcommelin approved these changes May 21, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels May 21, 2023
@bors
Copy link

bors bot commented May 22, 2023

Merge conflict.

@ChrisHughes24
Copy link
Member

bors merge

@ChrisHughes24
Copy link
Member

bors r-

@bors
Copy link

bors bot commented May 22, 2023

Canceled.

@ChrisHughes24 ChrisHughes24 removed the ready-to-merge This PR has been sent to bors. label May 22, 2023
@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels May 22, 2023
bors bot pushed a commit that referenced this pull request May 22, 2023
@int-y1 @ChrisHughes24
feat: port RingTheory.DiscreteValuationRing.Basic (#4156)
c05891b 
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
@bors
Copy link

bors bot commented May 22, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request May 22, 2023
@int-y1 @ChrisHughes24
feat: port RingTheory.DiscreteValuationRing.Basic (#4156)
e8f2fcb 
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
@bors
Copy link

bors bot commented May 22, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port RingTheory.DiscreteValuationRing.Basic [Merged by Bors] - feat: port RingTheory.DiscreteValuationRing.Basic May 22, 2023
@bors bors bot closed this May 22, 2023
@bors bors bot deleted the port/RingTheory.DiscreteValuationRing.Basic branch May 22, 2023 18:33
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@int-y1 @ChrisHughes24 @qawbecrdtey
feat: port RingTheory.DiscreteValuationRing.Basic (leanprover-communi…
1a4734d 
…ty#4156)

Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@int-y1 @ChrisHughes24 @jcommelin @semorrison