Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port RingTheory.GradedAlgebra.HomogeneousIdeal #4159

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - feat: port RingTheory.GradedAlgebra.HomogeneousIdeal #4159

wants to merge 8 commits into from

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented May 21, 2023

Open in Gitpod

@int-y1
feat: port RingTheory.GradedAlgebra.HomogeneousIdeal
2a582a7
@int-y1
Initial file copy from mathport
b39814f
@int-y1
automated fixes
73ac6ec 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@int-y1
easy fixes
7eb73b0
@int-y1 int-y1 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels May 21, 2023
@int-y1 int-y1 added awaiting-review The author would like community review of the PR awaiting-CI and removed WIP Work in progress labels May 21, 2023
@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 21, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label May 21, 2023
@bors
Copy link

bors bot commented May 21, 2023

Merge conflict.

@ChrisHughes24 ChrisHughes24 removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label May 21, 2023
@ChrisHughes24
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request May 21, 2023
@int-y1 @Parcly-Taxel
feat: port RingTheory.GradedAlgebra.HomogeneousIdeal (#4159)
54991d4 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented May 21, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port RingTheory.GradedAlgebra.HomogeneousIdeal [Merged by Bors] - feat: port RingTheory.GradedAlgebra.HomogeneousIdeal May 21, 2023
@bors bors bot closed this May 21, 2023
@bors bors bot deleted the port/RingTheory.GradedAlgebra.HomogeneousIdeal branch May 21, 2023 15:13
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@int-y1 @Parcly-Taxel @qawbecrdtey
feat: port RingTheory.GradedAlgebra.HomogeneousIdeal (leanprover-comm…
3f62522 
…unity#4159)

Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@int-y1 @ChrisHughes24 @semorrison @Parcly-Taxel