Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Algebra.Category.Ring.Colimits #4164

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat: port Algebra.Category.Ring.Colimits #4164

wants to merge 9 commits into from

Conversation

jjaassoonn
Copy link
Collaborator

Open in Gitpod

@jjaassoonn
feat: port Algebra.Category.Ring.Colimits
b07383e
@jjaassoonn
Initial file copy from mathport
cb25d4f
@jjaassoonn
automated fixes
52d841e 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@jjaassoonn jjaassoonn added the mathlib-port This is a port of a theory file from mathlib. label May 21, 2023
@jjaassoonn jjaassoonn marked this pull request as ready for review May 22, 2023 02:03
@jjaassoonn jjaassoonn added awaiting-review The author would like community review of the PR awaiting-CI labels May 22, 2023
@ChrisHughes24 ChrisHughes24 added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels May 22, 2023
@jjaassoonn jjaassoonn added awaiting-review The author would like community review of the PR awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels May 22, 2023
jcommelin
jcommelin approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 22, 2023
@bors
Copy link

bors bot commented May 22, 2023

Merge conflict.

@ChrisHughes24
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request May 23, 2023
@jjaassoonn @Parcly-Taxel
feat: port Algebra.Category.Ring.Colimits (#4164)
b2a9302 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented May 23, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Algebra.Category.Ring.Colimits [Merged by Bors] - feat: port Algebra.Category.Ring.Colimits May 23, 2023
@bors bors bot closed this May 23, 2023
@bors bors bot deleted the port/Algebra.Category.Ring.Colimits branch May 23, 2023 11:05
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@jjaassoonn @Parcly-Taxel @qawbecrdtey
feat: port Algebra.Category.Ring.Colimits (leanprover-community#4164)
4f96d77 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

@semorrison semorrison Awaiting requested review from semorrison

@ChrisHughes24 ChrisHughes24 Awaiting requested review from ChrisHughes24

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jjaassoonn @ChrisHughes24 @jcommelin @semorrison @Parcly-Taxel