Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port LinearAlgebra.Matrix.Charpoly.Coeff #4169

Closed
wants to merge 7 commits into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented May 21, 2023

Most of the file had minor fixes. I added porting notes for everything that was not just a capitalization issue.

I tried to fix all the capitalization issues in the first actual commit (2492f1c).

The next commit (b59a8cf) contains all the porting notes.

I still have not managed to fix one of the proofs, though.


Open in Gitpod

@adomani adomani added mathlib-port This is a port of a theory file from mathlib. WIP Work in progress labels May 21, 2023
@adomani adomani added awaiting-review awaiting-CI and removed WIP Work in progress labels May 21, 2023
@ChrisHughes24
Copy link
Member

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels May 21, 2023
bors bot pushed a commit that referenced this pull request May 21, 2023
Most of the file had minor fixes.  I added porting notes for everything that was not just a capitalization issue.

I tried to fix all the capitalization issues in the first actual commit (2492f1c).

The next commit (b59a8cf) contains all the porting notes.

I still have not managed to fix one of the proofs, though.



Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@bors
Copy link

bors bot commented May 21, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port LinearAlgebra.Matrix.Charpoly.Coeff [Merged by Bors] - feat: port LinearAlgebra.Matrix.Charpoly.Coeff May 21, 2023
@bors bors bot closed this May 21, 2023
@bors bors bot deleted the port/LinearAlgebra.Matrix.Charpoly.Coeff branch May 21, 2023 17:38
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
…4169)

Most of the file had minor fixes.  I added porting notes for everything that was not just a capitalization issue.

I tried to fix all the capitalization issues in the first actual commit (2492f1c).

The next commit (b59a8cf) contains all the porting notes.

I still have not managed to fix one of the proofs, though.



Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants