[Merged by Bors] - [Merged by Bors] - feat: port Analysis.PSeries #4182
Conversation
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
mcdoll
added
WIP
j-loreaux
added
awaiting-review
| section pow_macro | ||
| -- porting note: without these local macro rules Lean fails to elaborate `^` properly. | ||
| -- See https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/!4.234085 | ||
| local macro_rules | `($x ^ $y) => `(HPow.hPow $x $y) |
There was a problem hiding this comment.
@digama0 Do you understand what the correct solution is here?
There was a problem hiding this comment.
Aha: this work-around has been discussed here https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/!4.234085/near/361005815 .
semorrison
added
ready-to-merge
Removed the `simp` attribute on one lemma because `simpNF` was timing out trying to reduce the LHS. See [Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/looping.20in.20.60simp.60.20set) for the problem. Once this error is corrected with `simp`, we should be able to add the attribute again. Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Removed the `simp` attribute on one lemma because `simpNF` was timing out trying to reduce the LHS. See [Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/looping.20in.20.60simp.60.20set) for the problem. Once this error is corrected with `simp`, we should be able to add the attribute again. Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Removed the
simpattribute on one lemma becausesimpNFwas timing out trying to reduce the LHS. See Zulip for the problem. Once this error is corrected withsimp, we should be able to add the attribute again.