Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port Topology.ContinuousFunction.Compact #4183

Closed
wants to merge 9 commits into from

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented May 22, 2023


todo:

  • (optional) in the docs, find the lean 4 equivalent of bounded_continuous_function.equiv_continuous_map_of_compact
    update: this was renamed to continuous_map.equiv_bounded_of_compact in leanprover-community/mathlib@832a2eb
  • addEquivBoundedOfCompact ran into a maximum recursion depth error in @[simps] (Note: just worked around this by adding the simp lemmas manually)
  • instance : NormedAlgebra fields missing

Open in Gitpod

Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@int-y1 int-y1 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels May 22, 2023
@int-y1 int-y1 added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels May 22, 2023
@j-loreaux j-loreaux added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels May 24, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 25, 2023
bors bot pushed a commit that referenced this pull request May 25, 2023
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
@bors
Copy link

bors bot commented May 25, 2023

This PR was included in a batch that was canceled, it will be automatically retried

bors bot pushed a commit that referenced this pull request May 25, 2023
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
@bors
Copy link

bors bot commented May 25, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Topology.ContinuousFunction.Compact [Merged by Bors] - feat: port Topology.ContinuousFunction.Compact May 25, 2023
@bors bors bot closed this May 25, 2023
@bors bors bot deleted the port/Topology.ContinuousFunction.Compact branch May 25, 2023 11:19
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants