Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Topology.VectorBundle.Basic #4187

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat: port Topology.VectorBundle.Basic #4187

wants to merge 9 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented May 22, 2023

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels May 22, 2023
@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 22, 2023
bors bot pushed a commit that referenced this pull request May 22, 2023
@urkud
feat: port Topology.VectorBundle.Basic (#4187)
cb9977a
@hrmacbeth
Copy link
Member

As noted at the port status wiki
https://leanprover-community.github.io/mathlib-port-status/file/topology/vector_bundle/basic
could we wait a few days before merging this port? I noticed a "duplicate non-defeq instance" problem in the vector bundle API last night which might require a change in this file to fix.

@bors
Copy link

bors bot commented May 22, 2023

This PR was included in a batch that was canceled, it will be automatically retried

bors bot pushed a commit that referenced this pull request May 22, 2023
@urkud
feat: port Topology.VectorBundle.Basic (#4187)
2acd194
@bors
Copy link

bors bot commented May 22, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Topology.VectorBundle.Basic [Merged by Bors] - feat: port Topology.VectorBundle.Basic May 22, 2023
@bors bors bot closed this May 22, 2023
@bors bors bot deleted the port/Topology.VectorBundle.Basic branch May 22, 2023 17:42
@eric-wieser
Copy link
Member

@hrmacbeth, it looks like your request was ignored.

@urkud, can you please check the port dashboard in future before porting things? Both this PR and #4254 have a comment requesting a pause.

@urkud
Copy link
Member Author

urkud commented May 23, 2023

We've already discussed this in person. There was no comment (at least, on the port status page) when I started working on this file. I will forward port Heather's changes once they're ready.

qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@urkud @qawbecrdtey
feat: port Topology.VectorBundle.Basic (leanprover-community#4187)
983c500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urkud @ChrisHughes24 @hrmacbeth @eric-wieser