Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port LinearAlgebra.BilinearForm #4202

Closed
wants to merge 10 commits into from
Closed

[Merged by Bors] - feat: port LinearAlgebra.BilinearForm #4202

wants to merge 10 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

Open in Gitpod

@Ruben-VandeVelde
feat: port LinearAlgebra.BilinearForm
b2884bd
@Ruben-VandeVelde
Initial file copy from mathport
0e164d7
@Ruben-VandeVelde
automated fixes
5004806 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Ruben-VandeVelde Ruben-VandeVelde added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels May 22, 2023
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels May 22, 2023
@Parcly-Taxel
Copy link
Collaborator

I think the right name for IsOrthoᵢ is IsOrthoSet as it deals with a set of vectors.

@ChrisHughes24
Copy link
Member

IsOrthoSet

It's probably iIsOrtho in fact, according to the new convention. It's not a Set it's an indexed family. This is very important here as a Set cannot contain duplicates, but an indexed family can. This comes up in LinearIndependence, for example, the Set of columns of the matrix [[1,1],[1,1]] is linear independent, because it has one element, but the family of columns is not linear independent.

@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 22, 2023
bors bot pushed a commit that referenced this pull request May 22, 2023
@Ruben-VandeVelde @Parcly-Taxel @ChrisHughes24
feat: port LinearAlgebra.BilinearForm (#4202)
17bda6c 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
@bors
Copy link

bors bot commented May 22, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request May 22, 2023
@Ruben-VandeVelde @Parcly-Taxel @ChrisHughes24
feat: port LinearAlgebra.BilinearForm (#4202)
69632ee 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
@bors
Copy link

bors bot commented May 22, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port LinearAlgebra.BilinearForm [Merged by Bors] - feat: port LinearAlgebra.BilinearForm May 22, 2023
@bors bors bot closed this May 22, 2023
@bors bors bot deleted the port/LinearAlgebra.BilinearForm branch May 22, 2023 18:01
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@Ruben-VandeVelde @Parcly-Taxel
@ChrisHughes24 @qawbecrdtey
feat: port LinearAlgebra.BilinearForm (leanprover-community#4202)
12d89fc 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Co-authored-by: Chris Hughes <chrishughes24@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ruben-VandeVelde @Parcly-Taxel @ChrisHughes24