Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port Analysis.Calculus.Fderiv.Bilinear #4221

Closed
wants to merge 10 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented May 22, 2023

Also golf/extend theorems about bounded bilinear maps and rewrite the proof using the fact that the derivative of a bilinear map is a continuous bilinear map.


Open in Gitpod

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label May 22, 2023
@urkud urkud force-pushed the port/Analysis.Calculus.Fderiv.Bilinear branch 2 times, most recently from 852ba28 to 7444c5b Compare May 22, 2023 21:03
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label May 22, 2023
@urkud urkud added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels May 22, 2023
Add `IsBoundedBilinearMap.toContinuousLinearMap` and use it to golf
proofs by reusing facts about bundled bilinear maps
`E →L[𝕜] F →L[𝕜] G`.
@semorrison semorrison added the blocked-by-math-PR This PR depends on another PR to Mathlib label May 22, 2023
urkud added 5 commits May 22, 2023 18:28
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@eric-wieser
Copy link
Member

Also golf/extend theorems about bounded bilinear maps

Why are we doing this during porting?

@urkud
Copy link
Member Author

urkud commented May 23, 2023

It was easier for me to rewrite the proof than to fix it. Also, why not? My modifications are backwards compatible.

Copy link
Member

@fpvandoorn fpvandoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new file looks good

bors d+

@bors
Copy link

bors bot commented May 24, 2023

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels May 24, 2023
@urkud urkud removed the blocked-by-math-PR This PR depends on another PR to Mathlib label May 25, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@urkud
Copy link
Member Author

urkud commented May 25, 2023

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label May 25, 2023
bors bot pushed a commit that referenced this pull request May 25, 2023
Also golf/extend theorems about bounded bilinear maps and rewrite the proof using the fact that the derivative of a bilinear map is a continuous bilinear map.
@bors
Copy link

bors bot commented May 25, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Analysis.Calculus.Fderiv.Bilinear [Merged by Bors] - feat: port Analysis.Calculus.Fderiv.Bilinear May 25, 2023
@bors bors bot closed this May 25, 2023
@bors bors bot deleted the port/Analysis.Calculus.Fderiv.Bilinear branch May 25, 2023 08:45
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
Also golf/extend theorems about bounded bilinear maps and rewrite the proof using the fact that the derivative of a bilinear map is a continuous bilinear map.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants