Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port RingTheory.Localization.Integral #4231

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat: port RingTheory.Localization.Integral #4231

wants to merge 9 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde commented May 22, 2023 •
edited
Loading

@Ruben-VandeVelde Ruben-VandeVelde added the mathlib-port This is a port of a theory file from mathlib. label May 22, 2023
@semorrison semorrison added the blocked-by-other-PR This PR depends on another PR to Mathlib label May 22, 2023
@Ruben-VandeVelde Ruben-VandeVelde added help-wanted The author needs attention to resolve issues WIP Work in progress labels May 22, 2023
@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR to Mathlib label May 22, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@Ruben-VandeVelde
feat: port RingTheory.Localization.Integral
0487852
@Ruben-VandeVelde
Initial file copy from mathport
0cca6b6
@Ruben-VandeVelde
automated fixes
1208157 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Ruben-VandeVelde
Initial fixes
e6c9ccd
@Ruben-VandeVelde Ruben-VandeVelde force-pushed the port/RingTheory.Localization.Integral branch from 5587aca to e6c9ccd Compare May 22, 2023 19:56
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels May 23, 2023
@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 23, 2023
@bors
Copy link

bors bot commented May 23, 2023

Canceled.

@ChrisHughes24
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request May 23, 2023
@Ruben-VandeVelde
feat: port RingTheory.Localization.Integral (#4231)
d865f0c
@bors
Copy link

bors bot commented May 23, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port RingTheory.Localization.Integral [Merged by Bors] - feat: port RingTheory.Localization.Integral May 23, 2023
@bors bors bot closed this May 23, 2023
@bors bors bot deleted the port/RingTheory.Localization.Integral branch May 23, 2023 11:05
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@Ruben-VandeVelde @qawbecrdtey
feat: port RingTheory.Localization.Integral (leanprover-community#4231)
2586500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisHughes24 ChrisHughes24 Awaiting requested review from ChrisHughes24

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ruben-VandeVelde @semorrison @ChrisHughes24