[Merged by Bors] - feat: minimal port of Fintype #429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semorrison
added
the
awaiting-review
digama0
changed the title
|
Note: the commit convention for lean 4 no longer puts the file name in the commit message. |
|
It is intentional, although I don't mind nolinting the definitions if you think we should delay documenting it. (Use |
digama0
reviewed
Sep 19, 2022
1 task
|
I made some minor style changes and golfed the proof of bors d+ |
|
✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with |
|
Thanks, looks great. bors merge |
bors bot
pushed a commit
that referenced
this pull request
Sep 23, 2022
This is a bare minimum port of the definitions of `Finset` / `Multiset` / `Fintype`. I am hoping that these are enough to port the `fin_cases` tactic. (i.e. replacing the unfinished work in #346, which still had sorries in the corresponding material) Where possible I have started by copying and pasting the output from `mathlib3port`. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Mario Carneiro <di.gama@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
- [x] depends on: #429 Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
bors bot
pushed a commit
that referenced
this pull request
Oct 8, 2022
- [x] depends on: #429 Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bare minimum port of the definitions of
Finset/Multiset/Fintype. I am hoping that these are enough to port thefin_casestactic. (i.e. replacing the unfinished work in #346, which still had sorries in the corresponding material)Where possible I have started by copying and pasting the output from
mathlib3port.