New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: port SetTheory.Game.Basic #4311
Conversation
QuinnLesquimau
commented
May 24, 2023
There was no activity here for ~2 weeks, so I assume that you are not actively working on this PR. I'll add |
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
6579e7d
to
19524b5
Compare
I got |
@Parcly-Taxel the new lemmas you just added, e.g.
seem unlikely to be useful to me. At least for this file, we don't need them. Could you either:
|
I don't know how to get the
as shown in the infoview doesn't work. But there has to be a way to do so. |
…munity/mathlib4 into port/SetTheory.Game.Basic
Mathlib/SetTheory/Game/Basic.lean
Outdated
rfl | ||
#align pgame.mul_move_right_inr PGame.mul_moveRight_inr | ||
|
||
-- @[simp] -- Porting note: removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should say why, please: "simpNF linter complains".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(and below)
Okay, I've created a lean4 issue for the @Parcly-Taxel, if you could just fix the porting notes then I think we can merge. |
@semorrison OK, done. |
Bors merge |
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: David Renshaw <dwrenshaw@gmail.com> Co-authored-by: Parcly Taxel <reddeloostw@gmail.com> Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: David Renshaw <dwrenshaw@gmail.com> Co-authored-by: Parcly Taxel <reddeloostw@gmail.com> Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: David Renshaw <dwrenshaw@gmail.com> Co-authored-by: Parcly Taxel <reddeloostw@gmail.com> Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: David Renshaw <dwrenshaw@gmail.com> Co-authored-by: Parcly Taxel <reddeloostw@gmail.com> Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>