Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port SetTheory.Game.Basic #4311

Closed
wants to merge 19 commits into from

Conversation

QuinnLesquimau
Copy link
Collaborator


Open in Gitpod

@QuinnLesquimau QuinnLesquimau added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels May 24, 2023
@urkud
Copy link
Member

urkud commented Jun 7, 2023

There was no activity here for ~2 weeks, so I assume that you are not actively working on this PR. I'll add help-wanted so that anyone can contribute without an explicit permission from the author.

@urkud urkud added the help-wanted The author needs attention to resolve issues label Jun 7, 2023
@dwrensha
Copy link
Member

I got quot_left_distrib and quot_mul_assoc working. Now the only remaining task I see is to resolve some simpNF linter issues.

@semorrison semorrison added awaiting-review The author would like community review of the PR awaiting-CI and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Jun 26, 2023
@semorrison
Copy link
Contributor

semorrison commented Jun 26, 2023

@Parcly-Taxel the new lemmas you just added, e.g.

@[simp]
theorem neg_mk_mul_moveLeft_inl' {xl xr yl yr} {xL xR yL yR} {i j} :
    -(mk xl xr xL xR * mk yl yr yL yR).moveRight
    (@FunLike.coe _ _ (fun _ => RightMoves (mk xl xr xL xR * mk yl yr yL yR))
      Equiv.instFunLikeEquiv toLeftMovesNeg.symm (Sum.inl (i, j))) =
    -(xL i * mk yl yr yL yR + mk xl xr xL xR * yR j - xL i * yR j) :=
  rfl

seem unlikely to be useful to me. At least for this file, we don't need them. Could you either:

  • remove them
  • working out how to reformulate them in some way that is still useful, but doesn't have @FunLike.coe?

@semorrison semorrison added WIP Work in progress and removed awaiting-review The author would like community review of the PR labels Jun 26, 2023
@Parcly-Taxel
Copy link
Collaborator

Parcly-Taxel commented Jun 26, 2023

@Parcly-Taxel the new lemmas you just added, e.g.

@[simp]
theorem neg_mk_mul_moveLeft_inl' {xl xr yl yr} {xL xR yL yR} {i j} :
    -(mk xl xr xL xR * mk yl yr yL yR).moveRight
    (@FunLike.coe _ _ (fun _ => RightMoves (mk xl xr xL xR * mk yl yr yL yR))
      Equiv.instFunLikeEquiv toLeftMovesNeg.symm (Sum.inl (i, j))) =
    -(xL i * mk yl yr yL yR + mk xl xr xL xR * yR j - xL i * yR j) :=
  rfl

seem unlikely to be useful to me. At least for this file, we don't need them. Could you either:

* remove them

* working out how to reformulate them in some way that is still useful, but doesn't have `@FunLike.coe`?

I don't know how to get the FunLike.coe out –

toRightMovesNeg.symm (Sum.inr (i, j))

as shown in the infoview doesn't work. But there has to be a way to do so.

@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jun 26, 2023
…munity/mathlib4 into port/SetTheory.Game.Basic
rfl
#align pgame.mul_move_right_inr PGame.mul_moveRight_inr

-- @[simp] -- Porting note: removed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should say why, please: "simpNF linter complains".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and below)

@semorrison
Copy link
Contributor

Okay, I've created a lean4 issue for the termination_by problem (or at least something closely related?).

@Parcly-Taxel, if you could just fix the porting notes then I think we can merge.

@Parcly-Taxel
Copy link
Collaborator

@semorrison OK, done.

@semorrison
Copy link
Contributor

Bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 26, 2023
bors bot pushed a commit that referenced this pull request Jun 26, 2023
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: David Renshaw <dwrenshaw@gmail.com>
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Jun 26, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port SetTheory.Game.Basic [Merged by Bors] - feat: port SetTheory.Game.Basic Jun 26, 2023
@bors bors bot closed this Jun 26, 2023
@bors bors bot deleted the port/SetTheory.Game.Basic branch June 26, 2023 05:18
semorrison added a commit that referenced this pull request Jun 28, 2023
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: David Renshaw <dwrenshaw@gmail.com>
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: David Renshaw <dwrenshaw@gmail.com>
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
semorrison added a commit that referenced this pull request Aug 14, 2023
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: David Renshaw <dwrenshaw@gmail.com>
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants