Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port AlgebraicGeometry.PrimeSpectrum.Maximal #4323

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat: port AlgebraicGeometry.PrimeSpectrum.Maximal #4323

wants to merge 4 commits into from

Conversation

Parcly-Taxel
Copy link
Collaborator

Open in Gitpod

@Parcly-Taxel
feat: port AlgebraicGeometry.PrimeSpectrum.Maximal
06f636e
@Parcly-Taxel
Initial file copy from mathport
f90e275
@Parcly-Taxel
automated fixes
aee7318 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Parcly-Taxel
Fix errors
ee98137
@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. awaiting-CI labels May 25, 2023
jcommelin
jcommelin approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 25, 2023
bors bot pushed a commit that referenced this pull request May 25, 2023
@Parcly-Taxel
feat: port AlgebraicGeometry.PrimeSpectrum.Maximal (#4323)
286848a
@bors
Copy link

bors bot commented May 25, 2023

This PR was included in a batch that was canceled, it will be automatically retried

bors bot pushed a commit that referenced this pull request May 25, 2023
@Parcly-Taxel
feat: port AlgebraicGeometry.PrimeSpectrum.Maximal (#4323)
6994f45
@bors
Copy link

bors bot commented May 25, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port AlgebraicGeometry.PrimeSpectrum.Maximal [Merged by Bors] - feat: port AlgebraicGeometry.PrimeSpectrum.Maximal May 25, 2023
@bors bors bot closed this May 25, 2023
@bors bors bot deleted the port/AlgebraicGeometry.PrimeSpectrum.Maximal branch May 25, 2023 11:18
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@Parcly-Taxel @qawbecrdtey
feat: port AlgebraicGeometry.PrimeSpectrum.Maximal (leanprover-commun…
f906a2f 
…ity#4323)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Parcly-Taxel @jcommelin @semorrison