Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: weaken assumptions in lemmas about fderivWithin #4330

Closed
wants to merge 4 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented May 25, 2023

This is a partial forward-port of leanprover-community/mathlib#19045.

I only forward-ported 1 file that was already merged into
master. I'll do some git history rewrites in pending PRs instead.


Files Order.Filter.Basic and Topology.ContinuousOn are a part of the dependency.

Open in Gitpod

urkud added 2 commits May 25, 2023 01:12
Forward-port leanprover-community/mathlib#19070:

- add `Filter.set_eventuallyLE_iff_mem_inf_principal`,
`Filter.set_eventuallyLE_iff_inf_principal_le`, and
`Filter.set_eventuallyEq_iff_inf_principal`;
- golf `nhdsWithin_eq_iff_eventuallyEq` and `nhdsWithin_le_iff`.

The original PR golfs one more lemma which was already golfed to 1
line in Mathlib 4.
@urkud urkud added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged and removed mathlib-port This is a port of a theory file from mathlib. labels May 25, 2023
@semorrison semorrison added blocked-by-other-PR This PR depends on another PR which is still in the queue. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. labels May 25, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 25, 2023
bors bot pushed a commit that referenced this pull request May 25, 2023
This is a partial forward-port of leanprover-community/mathlib#19045.

I only forward-ported 1 file that was already merged into
`master`. I'll do some git history rewrites in pending PRs instead.
@bors
Copy link

bors bot commented May 25, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: weaken assumptions in lemmas about fderivWithin [Merged by Bors] - feat: weaken assumptions in lemmas about fderivWithin May 25, 2023
@bors bors bot closed this May 25, 2023
@bors bors bot deleted the forward-port-19045 branch May 25, 2023 21:39
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
…ommunity#4330)

This is a partial forward-port of leanprover-community/mathlib#19045.

I only forward-ported 1 file that was already merged into
`master`. I'll do some git history rewrites in pending PRs instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants