Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port Analysis.InnerProductSpace.Projection #4393

Closed
wants to merge 11 commits into from

Conversation

Komyyy
Copy link
Collaborator

@Komyyy Komyyy commented May 26, 2023

This PR also increase the priority of Submodule.bot_ext.


Open in Gitpod

@Komyyy Komyyy added blocked-by-other-PR This PR depends on another PR which is still in the queue. awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. awaiting-CI labels May 26, 2023
@Parcly-Taxel
Copy link
Collaborator

You don't need to make #4390 a separate PR, since it's so small and it helps just this PR. You can close #4390 and incorporate its change into here.

@Komyyy Komyyy removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label May 26, 2023
@Komyyy
Copy link
Collaborator Author

Komyyy commented May 26, 2023

@Parcly-Taxel I closed #4390.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 26, 2023
@jcommelin
Copy link
Member

Whoops, CI wasn't done yet.

bors r-

bors d+

@bors
Copy link

bors bot commented May 26, 2023

✌️ Komyyy can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bors
Copy link

bors bot commented May 26, 2023

Canceled.

@jcommelin
Copy link
Member

bors d=j-loreaux

@bors
Copy link

bors bot commented May 26, 2023

✌️ j-loreaux can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@j-loreaux
Copy link
Collaborator

bors merge

bors bot pushed a commit that referenced this pull request May 26, 2023
This PR also increase the priority of `Submodule.bot_ext`.



Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
@bors
Copy link

bors bot commented May 26, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Analysis.InnerProductSpace.Projection [Merged by Bors] - feat: port Analysis.InnerProductSpace.Projection May 26, 2023
@bors bors bot closed this May 26, 2023
@bors bors bot deleted the port/Analysis.InnerProductSpace.Projection branch May 26, 2023 17:27
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
…y#4393)

This PR also increase the priority of `Submodule.bot_ext`.



Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants