Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port RingTheory.RingHomProperties #4404

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: port RingTheory.RingHomProperties #4404

wants to merge 7 commits into from

Conversation

nick-kuhn
Copy link
Collaborator

Open in Gitpod

@nick-kuhn nick-kuhn added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels May 26, 2023
@mo271 mo271 force-pushed the port/RingTheory.RingHomProperties branch from dbf5da4 to 339da09 Compare June 8, 2023 06:17
@Ruben-VandeVelde
Copy link
Collaborator

@nick-kuhn @mo271 what's the status here? If you'd like someone else to help out, please add help-wanted and remove WIP

@nick-kuhn
Copy link
Collaborator Author

There are some horribly long terms showing up from the construction of localization morphisms. I was hoping to look into it, but haven't been making much progress.

@nick-kuhn nick-kuhn added help-wanted The author needs attention to resolve issues WIP Work in progress and removed WIP Work in progress help-wanted The author needs attention to resolve issues labels Jun 12, 2023
@nick-kuhn nick-kuhn added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jun 12, 2023
jcommelin
jcommelin approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 13, 2023
bors bot pushed a commit that referenced this pull request Jun 13, 2023
@nick-kuhn @mo271
feat: port RingTheory.RingHomProperties (#4404)
802488e 
Co-authored-by: Moritz Firsching <firsching@google.com>
@bors
Copy link

bors bot commented Jun 13, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port RingTheory.RingHomProperties [Merged by Bors] - feat: port RingTheory.RingHomProperties Jun 13, 2023
@bors bors bot closed this Jun 13, 2023
@bors bors bot deleted the port/RingTheory.RingHomProperties branch June 13, 2023 07:01
alexkeizer pushed a commit that referenced this pull request Jun 22, 2023
@nick-kuhn @mo271 @alexkeizer
feat: port RingTheory.RingHomProperties (#4404)
9113fec 
Co-authored-by: Moritz Firsching <firsching@google.com>
semorrison pushed a commit that referenced this pull request Jun 25, 2023
@nick-kuhn @mo271 @semorrison
feat: port RingTheory.RingHomProperties (#4404)
7ed9253 
Co-authored-by: Moritz Firsching <firsching@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nick-kuhn @Ruben-VandeVelde @jcommelin @semorrison @mo271