Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Geometry.Euclidean.Basic #4406

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - feat: port Geometry.Euclidean.Basic #4406

wants to merge 8 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

Open in Gitpod

@Ruben-VandeVelde
feat: port Geometry.Euclidean.Basic
445adc8
@Ruben-VandeVelde
Initial file copy from mathport
8984710
@Ruben-VandeVelde
automated fixes
9954f8e 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Ruben-VandeVelde Ruben-VandeVelde added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels May 26, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label May 26, 2023
@Parcly-Taxel
Copy link
Collaborator

I already have the entire file fixed; I'm going to push.

@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label May 26, 2023
@Parcly-Taxel Parcly-Taxel mentioned this pull request May 26, 2023
Closed
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels May 26, 2023
@Ruben-VandeVelde
Copy link
Collaborator Author

@Parcly-Taxel thanks, but I'd suggest you focus on porting files that are not already being worked on

jcommelin
jcommelin approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 26, 2023
bors bot pushed a commit that referenced this pull request May 26, 2023
@Ruben-VandeVelde @Parcly-Taxel
feat: port Geometry.Euclidean.Basic (#4406)
4321641 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented May 26, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Geometry.Euclidean.Basic [Merged by Bors] - feat: port Geometry.Euclidean.Basic May 26, 2023
@bors bors bot closed this May 26, 2023
@bors bors bot deleted the port/Geometry.Euclidean.Basic branch May 26, 2023 23:33
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@Ruben-VandeVelde @Parcly-Taxel @qawbecrdtey
feat: port Geometry.Euclidean.Basic (leanprover-community#4406)
0a370af 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ruben-VandeVelde @Parcly-Taxel @jcommelin @semorrison