[Merged by Bors] - feat: port Analysis.InnerProductSpace.PiL2 #4420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruben-VandeVelde
added
WIP
Ruben-VandeVelde
force-pushed
the
port/Analysis.InnerProductSpace.PiL2
branch
from
5795af3
to
49ff1b4
Compare
Ruben-VandeVelde
added
WIP
|
The cause of |
Komyyy
added
WIP
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
Co-authored-by: Komyyy <pol_tta@outlook.jp>
Ruben-VandeVelde
force-pushed
the
port/Analysis.InnerProductSpace.PiL2
branch
from
ca1f8e5
to
fb7cdf7
Compare
semorrison
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
May 29, 2023
Some theorems in `Analysis.InnerProductSpace.Basic`, such as `Orthonormal.inner_right_finsupp`, accidentally gained a new `DecidableEq` hypothesis during the port. This removes the hypothesis by using `classical!` instead of `classical` in their proofs. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Komyyy <pol_tta@outlook.jp>
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
May 29, 2023
Some theorems in `Analysis.InnerProductSpace.Basic`, such as `Orthonormal.inner_right_finsupp`, accidentally gained a new `DecidableEq` hypothesis during the port. This removes the hypothesis by using `classical!` instead of `classical` in their proofs. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Komyyy <pol_tta@outlook.jp>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
eric-wieser
reviewed
May 29, 2023
Comment on lines
-793
to
+794
| classical simpa [Finsupp.total_apply, Finsupp.inner_sum, orthonormal_iff_ite.mp hv] using Eq.symm | ||
| classical! | ||
| simpa [Finsupp.total_apply, Finsupp.inner_sum, orthonormal_iff_ite.mp hv] using Eq.symm |
There was a problem hiding this comment.
Why did this file change? Does the content of the proof change the API here (due to pulling in unwanted DecidabeEqs)?
qawbecrdtey
pushed a commit
to qawbecrdtey/greedoid-mathlib4
that referenced
this pull request
Jun 12, 2023
Some theorems in `Analysis.InnerProductSpace.Basic`, such as `Orthonormal.inner_right_finsupp`, accidentally gained a new `DecidableEq` hypothesis during the port. This removes the hypothesis by using `classical!` instead of `classical` in their proofs. Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Komyyy <pol_tta@outlook.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some theorems in
Analysis.InnerProductSpace.Basic, such asOrthonormal.inner_right_finsupp, accidentally gained a newDecidableEqhypothesis during the port. This removes the hypothesis by usingclassical!instead ofclassicalin their proofs.