[Merged by Bors] - feat: port LinearAlgebra.QuadraticForm.Basic #4432
Conversation
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
urkud
added
help-wanted
Ruben-VandeVelde
added
awaiting-review
|
It looks like the new |
| -- Porting note: adding this instance prevents a timeout in `ext_ring_op` | ||
| instance {σ : R →+* S} : FunLike (M →ₛₗ[σ] M₃) M (λ _ ↦ M₃) := | ||
| { AddHomClass.toFunLike with } | ||
| instance instCoeFun {σ : R →+* S} : CoeFun (M →ₛₗ[σ] M₃) (λ _ ↦ M → M₃) := |
There was a problem hiding this comment.
What is the motivation for re-adding this instance?
There was a problem hiding this comment.
The reason is the same as we had in Lean 3: without this instance, Lean sometimes fails to find coercion to function. Note that I use FunLike.coe, not toFun, so it unfolds to the same expression. Possibly, we should change it everywhere.
There was a problem hiding this comment.
I removed this instance again, and fixed the 3 errors in the file-to-be-ported by making some arguments explicit.
| /-- Helper instance for when there's too many metavariables to apply | ||
| `FunLike.hasCoeToFun` directly. -/ | ||
| instance : CoeFun (QuadraticForm R M) fun _ => M → R := | ||
| ⟨FunLike.coe⟩ |
There was a problem hiding this comment.
I recall that we decided to only port the FunLike instances and skip the CoeFun instances (as also suggested by the comment in LinearMap). Did we change this at some point?
Vierkantor
added
awaiting-author
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
urkud
added
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: Johan Commelin <johan@commelin.net>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: Johan Commelin <johan@commelin.net>
I get compile failures in a seemingly unrelated file. Possibly, because of the new
instCoeFun.