Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port RingTheory.Ideal.Cotangent #4451

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat: port RingTheory.Ideal.Cotangent #4451

wants to merge 9 commits into from

Conversation

xroblot
Copy link
Collaborator

@xroblot xroblot commented May 28, 2023

Open in Gitpod

@xroblot xroblot added mathlib-port This is a port of a theory file from mathlib. awaiting-CI labels May 29, 2023
@xroblot xroblot added the awaiting-review The author would like community review of the PR label May 29, 2023
jcommelin
jcommelin reviewed May 29, 2023
View reviewed changes
Mathlib/RingTheory/Ideal/Cotangent.lean Outdated Show resolved Hide resolved
Mathlib/RingTheory/Ideal/Cotangent.lean Outdated Show resolved Hide resolved
jcommelin
jcommelin approved these changes May 29, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 29, 2023
bors bot pushed a commit that referenced this pull request May 29, 2023
@xroblot @jcommelin
feat: port RingTheory.Ideal.Cotangent (#4451)
63c05ba 
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented May 29, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port RingTheory.Ideal.Cotangent [Merged by Bors] - feat: port RingTheory.Ideal.Cotangent May 29, 2023
@bors bors bot closed this May 29, 2023
@bors bors bot deleted the port/RingTheory.Ideal.Cotangent branch May 29, 2023 12:57
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@xroblot @jcommelin @qawbecrdtey
feat: port RingTheory.Ideal.Cotangent (leanprover-community#4451)
b05dae8 
Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xroblot @jcommelin @semorrison