Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Algebra.Order.Interval #4464

Closed
wants to merge 14 commits into from
Closed

[Merged by Bors] - feat: port Algebra.Order.Interval #4464

wants to merge 14 commits into from

Conversation

int-y1
Copy link
Collaborator

@int-y1 int-y1 commented May 29, 2023 •
edited by xroblot

todo:

  • NonemptyInterval.subtractionCommMonoid errors with sub_eq_add_neg and neg_add_rev
  • NonemptyInterval.divisionCommMonoid same thing

Open in Gitpod

@int-y1
feat: port Algebra.Order.Interval
8001f25
@int-y1
Initial file copy from mathport
f2041d5
@int-y1
automated fixes
4ce4af8 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@int-y1
fix
b2cf470
@int-y1
fix 2
02a0272
@int-y1 int-y1 added help-wanted The author needs attention to resolve issues mathlib-port This is a port of a theory file from mathlib. labels May 29, 2023
@xroblot
Copy link
Collaborator

xroblot commented May 31, 2023

Pushed some fixes. It was necessary to apply two ext lemmas to recover the output of the ext from Mathlib3.

Beware when naming instances that there is already a namespace so it is not necessary to add it to the instance name.

@Komyyy Komyyy added the WIP Work in progress label Jun 7, 2023
@Komyyy
Copy link
Collaborator

Komyyy commented Jun 7, 2023

I'm working on the positivity extension.

@Komyyy Komyyy added awaiting-review The author would like community review of the PR awaiting-CI and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Jun 7, 2023
@jcommelin jcommelin added the t-meta Tactics, attributes or user commands label Jun 7, 2023
@semorrison
Copy link
Contributor

bors d+

@bors
Copy link

bors bot commented Jun 7, 2023

✌️ int-y1 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Jun 7, 2023
@int-y1
Copy link
Collaborator Author

int-y1 commented Jun 7, 2023

bors r+

bors bot pushed a commit that referenced this pull request Jun 7, 2023
@int-y1 @xroblot @Komyyy
feat: port Algebra.Order.Interval (#4464)
4eebfa2 
Co-authored-by: Xavier-François Roblot <46200072+xroblot@users.noreply.github.com>
Co-authored-by: Komyyy <pol_tta@outlook.jp>
@bors
Copy link

bors bot commented Jun 7, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Algebra.Order.Interval [Merged by Bors] - feat: port Algebra.Order.Interval Jun 7, 2023
@bors bors bot closed this Jun 7, 2023
@bors bors bot deleted the port/Algebra.Order.Interval branch June 7, 2023 18:26
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@int-y1 @xroblot
@Komyyy @qawbecrdtey
feat: port Algebra.Order.Interval (leanprover-community#4464)
4f33f46 
Co-authored-by: Xavier-François Roblot <46200072+xroblot@users.noreply.github.com>
Co-authored-by: Komyyy <pol_tta@outlook.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison semorrison left review comments

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib. t-meta Tactics, attributes or user commands
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@int-y1 @xroblot @Komyyy @semorrison @jcommelin