[Merged by Bors] - feat: port Analysis.NormedSpace.LpSpace #4465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
int-y1
added
WIP
int-y1
added
help-wanted
|
lots of errors remaining |
j-loreaux
added
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jun 1, 2023
Notes [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/!4.234465.20.60lp.60) : 1. There are both `CoeOut` and `CoeFun` instances for `lp E p`. This is consistent with mathlib3, but it seems strange and I would expect it to cause problems. 2. It seems there is some defeq abuse (identifiying `PreLp E` with `∀ i, E i` in the aforementioned `CoeOut` instance, for example) happening here which is rather convenient, but it's possible it may cause problems. (this abuse was also present in mathlib3) 3. What should the name of this file be? `LpSpace` seems wrong semantically, but `lpSpace` doesn't seem allowable by our file name conventions. Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: Moritz Firsching <firsching@google.com> Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
qawbecrdtey
pushed a commit
to qawbecrdtey/greedoid-mathlib4
that referenced
this pull request
Jun 12, 2023
Notes [Zulip thread](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/!4.234465.20.60lp.60) : 1. There are both `CoeOut` and `CoeFun` instances for `lp E p`. This is consistent with mathlib3, but it seems strange and I would expect it to cause problems. 2. It seems there is some defeq abuse (identifiying `PreLp E` with `∀ i, E i` in the aforementioned `CoeOut` instance, for example) happening here which is rather convenient, but it's possible it may cause problems. (this abuse was also present in mathlib3) 3. What should the name of this file be? `LpSpace` seems wrong semantically, but `lpSpace` doesn't seem allowable by our file name conventions. Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com> Co-authored-by: Moritz Firsching <firsching@google.com> Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes Zulip thread :
CoeOutandCoeFuninstances forlp E p. This is consistent with mathlib3, but it seems strange and I would expect it to cause problems.PreLp Ewith∀ i, E iin the aforementionedCoeOutinstance, for example) happening here which is rather convenient, but it's possible it may cause problems. (this abuse was also present in mathlib3)LpSpaceseems wrong semantically, butlpSpacedoesn't seem allowable by our file name conventions.