Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Analysis.Calculus.FDerivMeasurable #4468

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat: port Analysis.Calculus.FDerivMeasurable #4468

wants to merge 9 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde commented May 29, 2023 •
edited

Open questions:

  • did I get the capitalization around A/B/D right?
  • should the failing simp calls be investigated before merging?
  • should the failing apply_rules calls be investigated before merging?

Open in Gitpod

@Ruben-VandeVelde
feat: port Analysis.Calculus.FderivMeasurable
74b6f79
@Ruben-VandeVelde
Initial file copy from mathport
16d4a20
@Ruben-VandeVelde
automated fixes
b0427e1 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Ruben-VandeVelde
Move
f5355eb
@Ruben-VandeVelde Ruben-VandeVelde added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels May 29, 2023
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels May 29, 2023
@urkud
Copy link
Member

urkud commented May 29, 2023

LGTM. IMHO, we should merge this PR and possibly open github issues about failing simp/apply_rules.
bors d+

@bors
Copy link

bors bot commented May 29, 2023

✌️ Ruben-VandeVelde can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels May 29, 2023
@Ruben-VandeVelde @urkud
Apply suggestions from code review
c4e1628 
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@Ruben-VandeVelde
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request May 29, 2023
@Ruben-VandeVelde
feat: port Analysis.Calculus.FDerivMeasurable (#4468)
1196ccc
@bors
Copy link

bors bot commented May 29, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Analysis.Calculus.FDerivMeasurable [Merged by Bors] - feat: port Analysis.Calculus.FDerivMeasurable May 29, 2023
@bors bors bot closed this May 29, 2023
@bors bors bot deleted the port/Analysis.Calculus.FderivMeasurable branch May 29, 2023 19:05
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@Ruben-VandeVelde @qawbecrdtey
feat: port Analysis.Calculus.FDerivMeasurable (leanprover-community#4468
4e48fb8 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urkud urkud urkud left review comments

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ruben-VandeVelde @urkud